Added DataProviderDataRuleTest

Author: staabm

src/Rules/PHPUnit/DataProviderDataRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
+use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPUnit\Framework\TestCase;
 
@@ -14,6 +15,15 @@
  */
 class DataProviderDataRule implements Rule
 {
+	private ReflectionProvider $reflectionProvider;
+
+	public function __construct(
+		ReflectionProvider $reflectionProvider,
+	)
+	{
+		$this->reflectionProvider = $reflectionProvider;
+	}
+
 	public function getNodeType(): string
 	{
 		return Node\Stmt\Return_::class;
@@ -40,27 +50,29 @@ public function processNode(Node $node, Scope $scope): array
 
 		$classReflection = $scope->getClassReflection();
 
-		if ($classReflection === null || !$classReflection->is(TestCase::class)) {
+		if (
+			$classReflection === null
+			|| !$classReflection->is(TestCase::class)
+			|| $classReflection->isAbstract()
+		) {
 			return [];
 		}
 
 		// XXX check whether the method is used as a data provider
 
-		if (method_exists($scope, 'invokeNodeCallback')) {
-			foreach($node->expr->items as $item) {
-				if (!$item->value instanceof Node\Expr\Array_) {
-					return [];
-				}
-
-				$args = $this->arrayItemsToArgs($item->value);
-				$var = new Node\Expr\New_(new Node\Name('test'));
-				$scope->invokeNodeCallback(new Node\Expr\MethodCall(
-					$var,
-					'testTrim',
-					$args,
-					['startLine' => $item->getStartLine()]
-				));
+		foreach($node->expr->items as $item) {
+			if (!$item->value instanceof Node\Expr\Array_) {
+				return [];
 			}
+
+			$args = $this->arrayItemsToArgs($item->value);
+			$var = new Node\Expr\New_(new Node\Name($classReflection->getName()));
+			$scope->invokeNodeCallback(new Node\Expr\MethodCall(
+				$var,
+				'testTrim',
+				$args,
+				['startLine' => $item->getStartLine()]
+			));
 		}
 
 		return [];

tests/Rules/PHPUnit/DataProviderDataRuleTest.php

@@ -0,0 +1,47 @@
+<?php declare(strict_types=1);
+
+namespace Rules\PHPUnit;
+
+use PHPStan\Rules\PHPUnit\DataProviderDataRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<DataProviderDataRule>
+ */
+class DataProviderDataRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		$reflection = $this->createReflectionProvider();
+
+		return new DataProviderDataRule(
+			$reflection
+		);
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/data-provider-data.php'], [
+			[
+				'Parameter #2 $input of method test::testTrim() expects string, int given.',
+				25,
+			],
+			[
+				'Parameter #2 $input of method test::testTrim() expects string, false given.',
+				29,
+			],
+		]);
+	}
+
+	/**
+	 * @return string[]
+	 */
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/data-provider-data.neon',
+		];
+	}
+}

tests/Rules/PHPUnit/data-provider-data.neon

@@ -0,0 +1,5 @@
+includes:
+	- ../../../extension.neon
+
+rules:
+	- PHPStan\Rules\Methods\CallMethodsRule

tests/Rules/PHPUnit/data/data-provider-data.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace DataProviderDataTest;
+
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+
+class FooTest extends TestCase
+{
+
+	#[DataProvider('aProvider')]
+	public function testTrim(string $expectedResult, string $input): void
+	{
+	}
+
+	public function aProvider(): array /** @phpstan-ignore missingType.iterableValue */
+	{
+		return [
+			[
+				'Hello World',
+				" Hello World \n",
+			],
+			[
+				'Hello World',
+				123,
+			],
+			[
+				'Hello World',
+				false,
+			],
+		];
+	}
+}
+