Check arguments passed through forward_static_call() against the callable

Extend CallUserFuncRule to forward_static_call() and forward_static_call_array(),
reusing their argument normalization, so missing or mismatched arguments of the
forwarded callable are reported like for call_user_func(). The synthesized static
call's name nodes carry the original call's position attributes so the errors point
at the call site. Nonexistent methods are already covered by the generic callable
parameter check.

Author: zonuexe

src/Analyser/ArgumentsNormalizer.php

@@ -273,9 +273,11 @@ private static function createForwardingStaticCall(FuncCall $funcCall, Scope $sc
 			return null;
 		}
 
+		// The original call's position attributes are propagated to the name nodes too,
+		// so rule errors about the synthesized call point at the original call site.
 		return new StaticCall(
-			new FullyQualified($className),
-			new Identifier($methodName),
+			new FullyQualified($className, $funcCall->getAttributes()),
+			new Identifier($methodName, $funcCall->getAttributes()),
 			$funcCall->getArgs(),
 			$funcCall->getAttributes(),
 		);

src/Rules/Functions/CallUserFuncRule.php

@@ -62,6 +62,16 @@ public function processNode(Node $node, Scope&NodeCallbackInvoker&CollectedDataE
 				$node,
 				$scope,
 			);
+		} elseif ($functionName === 'forward_static_call') {
+			$result = ArgumentsNormalizer::reorderForwardStaticCallArguments(
+				$node,
+				$scope,
+			);
+		} elseif ($functionName === 'forward_static_call_array') {
+			$result = ArgumentsNormalizer::reorderForwardStaticCallArrayArguments(
+				$node,
+				$scope,
+			);
 		} else {
 			return [];
 		}

tests/PHPStan/Rules/Functions/CallUserFuncRuleTest.php

@@ -46,6 +46,32 @@ protected function getRule(): Rule
 	}
 
 	#[RequiresPhp('>= 8.0.0')]
+	public function testForwardStaticCall(): void
+	{
+		$this->analyse([__DIR__ . '/data/forward-static-call.php'], [
+			[
+				'Callable passed to forward_static_call() invoked with 0 parameters, 1 required.',
+				21,
+			],
+			[
+				'Parameter #1 $name of callable passed to forward_static_call() expects string, int given.',
+				22,
+			],
+			[
+				'Callable passed to forward_static_call() invoked with 0 parameters, 1 required.',
+				23,
+			],
+			[
+				'Callable passed to forward_static_call_array() invoked with 0 parameters, 1 required.',
+				25,
+			],
+			[
+				'Parameter #1 $name of callable passed to forward_static_call_array() expects string, int given.',
+				26,
+			],
+		]);
+	}
+
 	public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/call-user-func.php'], [

tests/PHPStan/Rules/Functions/data/forward-static-call.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace ForwardStaticCallRule;
+
+class Base
+{
+
+	public static function greet(string $name): string
+	{
+		return 'hi ' . $name;
+	}
+
+}
+
+class Caller extends Base
+{
+
+	public static function doFoo(): void
+	{
+		forward_static_call([Base::class, 'greet'], 'John');
+		forward_static_call([Base::class, 'greet']);
+		forward_static_call([Base::class, 'greet'], 42);
+		forward_static_call('ForwardStaticCallRule\Base::greet');
+		forward_static_call_array([Base::class, 'greet'], ['John']);
+		forward_static_call_array([Base::class, 'greet'], []);
+		forward_static_call_array([Base::class, 'greet'], [42]);
+	}
+
+}