Skip non ignorable errors

Author: ruudk

src/Analyser/AnalyserResultFinalizer.php

@@ -93,7 +93,11 @@ public function finalize(AnalyserResult $analyserResult, bool $onlyFiles, bool $
 			}
 		}
 
-		$tempCollectorErrors = array_filter($tempCollectorErrors, function (string $error) use ($scope, $node) : bool {
+		$tempCollectorErrors = array_filter($tempCollectorErrors, function (Error $error) use ($scope, $node) : bool {
+			if (! $error->canBeIgnored()) {
+				return true;
+			}
+
 			foreach ($this->ignoreErrorExtensionProvider->getExtensions() as $ignoreErrorExtension) {
 				if ($ignoreErrorExtension->shouldIgnore($error, $node, $scope)) {
 					return false;

src/Analyser/FileAnalyser.php

@@ -145,9 +145,11 @@ public function analyseFile(
 						foreach ($ruleErrors as $ruleError) {
 							$error = $this->ruleErrorTransformer->transform($ruleError, $scope, $nodeType, $node->getStartLine());
 
-							foreach ($this->ignoreErrorExtensionProvider->getExtensions() as $ignoreErrorExtension) {
-								if ($ignoreErrorExtension->shouldIgnore($error, $node, $scope)) {
-									continue 2;
+							if ($error->canBeIgnored()) {
+								foreach ($this->ignoreErrorExtensionProvider->getExtensions() as $ignoreErrorExtension) {
+									if ($ignoreErrorExtension->shouldIgnore($error, $node, $scope)) {
+										continue 2;
+									}
 								}
 							}
 
@@ -291,6 +293,10 @@ public function analyseFile(
 		}
 
 		$fileErrors = array_filter($fileErrors, function (Error $error) use ($scope) : bool {
+			if (! $error->canBeIgnored()) {
+				return true;
+			}
+
 			foreach ($this->ignoreErrorExtensionProvider->getExtensions() as $ignoreErrorExtension) {
 				if ($ignoreErrorExtension->shouldIgnore($error, null, $scope)) {
 					return false;