Fix incorrect analyzing of array_shift with non-empty-list property

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -2669,6 +2669,9 @@ static function (): void {
 					$isArrayPop ? $arrayArgType->popArray() : $arrayArgType->shiftArray(),
 					$isArrayPop ? $arrayArgNativeType->popArray() : $arrayArgNativeType->shiftArray(),
 				);
+				if ($arrayArg instanceof PropertyFetch || $arrayArg instanceof StaticPropertyFetch) {
+					$nodeCallback(new PropertyAssignNode($arrayArg, new TypeExpr($scope->getType($arrayArg)), false), $scope);
+				}
 			}
 
 			if (

tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php

@@ -819,4 +819,45 @@ public function testBug7824(): void
 		$this->analyse([__DIR__ . '/data/bug-7824.php'], []);
 	}
 
+	public function testBug13438(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13438.php'], [
+			[
+				'Property Bug13438\Test::$queue (non-empty-list<int>) does not accept list<int>.',
+				20,
+				'list<int> might be empty.',
+			],
+			[
+				'Property Bug13438\Test::$queue (non-empty-list<int>) does not accept list<int>.',
+				26,
+				'list<int> might be empty.',
+			],
+		]);
+	}
+
+	public function testBug13438b(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13438b.php'], [
+			[
+				'Property Bug13438b\Test::$queue (non-empty-list<int>) does not accept list<int>.',
+				20,
+				'list<int> might be empty.',
+			],
+			[
+				'Property Bug13438b\Test::$queue (non-empty-list<int>) does not accept list<int>.',
+				26,
+				'list<int> might be empty.',
+			],
+
+		]);
+	}
+
+	public function testBug13438c(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13438c.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-13438.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Bug13438;
+
+use LogicException;
+
+class Test
+{
+	/**
+	 * @param non-empty-list<int> $queue
+	 */
+	public function __construct(
+		private array $queue,
+	)
+	{
+	}
+
+	public function test1(): int
+	{
+		return array_shift($this->queue)
+			?? throw new LogicException('queue is empty');
+	}
+
+	public function test2(): int
+	{
+		return array_shift($this->queue);
+	}
+}

tests/PHPStan/Rules/Properties/data/bug-13438b.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Bug13438b;
+
+use LogicException;
+
+class Test
+{
+	/**
+	 * @param non-empty-list<int> $queue
+	 */
+	public function __construct(
+		private array $queue,
+	)
+	{
+	}
+
+	public function test1(): int
+	{
+		return array_pop($this->queue)
+			?? throw new LogicException('queue is empty');
+	}
+
+	public function test2(): int
+	{
+		return array_pop($this->queue);
+	}
+}

tests/PHPStan/Rules/Properties/data/bug-13438c.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Bug13438c;
+
+use LogicException;
+
+class Test
+{
+	/**
+	 * @var list<int>
+	 */
+	private $queue;
+
+	/**
+	 * @param non-empty-list<int> $queue
+	 */
+	public function __construct(
+		array $queue,
+	)
+	{
+		$this->queue = $queue;
+	}
+
+	public function test1(): int
+	{
+		return array_shift($this->queue)
+			?? throw new LogicException('queue is empty');
+	}
+
+	public function test2(): int
+	{
+		return array_shift($this->queue);
+	}
+}