Properties cannot be final

Author: staabm

src/Php/PhpVersion.php

@@ -357,6 +357,11 @@ public function supportsPropertyHooks(): bool
 		return $this->versionId >= 80400;
 	}
 
+	public function supportsNonPrivateFinalProperties(): bool
+	{
+		return $this->versionId >= 80400;
+	}
+
 	public function supportsAsymmetricVisibility(): bool
 	{
 		return $this->versionId >= 80400;

src/Rules/Properties/PropertyInClassRule.php

@@ -81,6 +81,18 @@ public function processNode(Node $node, Scope $scope): array
 			];
 		}
 
+			$node->isFinal()
+			&& !$node->hasHooks()
+			&& (!$this->phpVersion->supportsNonPrivateFinalProperties() || $node->isPrivate())
+		) {
+			return [
+				RuleErrorBuilder::message('Properties cannot be final.')
+					->nonIgnorable()
+					->identifier('property.final')
+					->build(),
+			];
+		}
+
 		if ($node->isPrivate()) {
 			if ($node->hasHooks()) {
 				if ($node->isFinal()) {

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -221,14 +221,49 @@ public function testPhp84AndPrivateFinalHookedProperties(): void
 
 		$this->analyse([__DIR__ . '/data/private-final-property-hooks.php'], [
 			[
-				'Hooked properties cannot be both final and private.',
+				'Properties cannot be both final and private.',
 				7,
 			],
 			[
-				'Hooked properties cannot be both final and private.',
+				'Properties cannot be both final and private.',
 				11,
 			],
 		]);
 	}
 
+	public function testPhp84FinalProperties(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		$this->analyse([__DIR__ . '/data/final-properties.php'], [
+			[
+				'Properties cannot be final.',
+				7,
+			],
+		]);
+	}
+	public function testBeforePhp84FinalProperties(): void
+	{
+		if (PHP_VERSION_ID >= 80400) {
+			$this->markTestSkipped('Test requires PHP 8.3 or earlier.');
+		}
+
+		$this->analyse([__DIR__ . '/data/final-properties.php'], [
+			[
+				'Properties cannot be final.',
+				7,
+			],
+			[
+				'Properties cannot be final.',
+				8,
+			],
+			[
+				'Properties cannot be final.',
+				9,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/final-properties.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace FinalProperties;
+
+final class User
+{
+	final private string $private = 'mailto: example.org';
+	final protected string $protected = 'mailto: example.org';
+	final public string $public = 'mailto: example.org';
+
+}