Fix analysis on array_map with named arguments

Author: takaram

src/Parser/ArrayMapArgVisitor.php

@@ -6,7 +6,7 @@
 use PhpParser\Node;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\DependencyInjection\AutowiredService;
-use function array_slice;
+use function array_splice;
 use function count;
 
 #[AutowiredService]
@@ -18,19 +18,41 @@ final class ArrayMapArgVisitor extends NodeVisitorAbstract
 	#[Override]
 	public function enterNode(Node $node): ?Node
 	{
-		if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {
-			$functionName = $node->name->toLowerString();
-			if ($functionName === 'array_map') {
-				$args = $node->getArgs();
-				if (isset($args[0])) {
-					$slicedArgs = array_slice($args, 1);
-					if (count($slicedArgs) > 0) {
-						$args[0]->value->setAttribute(self::ATTRIBUTE_NAME, $slicedArgs);
-					}
-				}
-			}
+		if (!$this->isArrayMapCall($node)) {
+			return null;
 		}
+
+		$args = $node->getArgs();
+		if (count($args) < 2) {
+			return null;
+		}
+
+		$callbackPos = 0;
+		if ($args[1]->name !== null && $args[1]->name->name === 'callback') {
+			$callbackPos = 1;
+		}
+		[$callback] = array_splice($args, $callbackPos, 1);
+		$callback->value->setAttribute(self::ATTRIBUTE_NAME, $args);
+
 		return null;
 	}
 
+	/**
+	 * @phpstan-assert-if-true Node\Expr\FuncCall $node
+	 */
+	private function isArrayMapCall(Node $node): bool
+	{
+		if (!$node instanceof Node\Expr\FuncCall) {
+			return false;
+		}
+		if (!$node->name instanceof Node\Name) {
+			return false;
+		}
+		if ($node->isFirstClassCallable()) {
+			return false;
+		}
+
+		return $node->name->toLowerString() === 'array_map';
+	}
+
 }

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2182,4 +2182,15 @@ public function testBug13065(): void
 		$this->analyse([__DIR__ . '/data/bug-13065.php'], $errors);
 	}
 
+	public function testBug12317(): void
+	{
+		if (PHP_VERSION_ID < 80000) {
+			$this->markTestSkipped('Test requires PHP 8.0.');
+		}
+
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-12317.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-12317.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12317;
+
+class Uuid {
+	public function __construct(public string $uuid) {}
+	public function __toString() { return $this->uuid; }
+}
+
+class HelloWorld
+{
+	/**
+	 * @param list<Uuid> $a
+	 *
+	 * @return list<string>
+	 */
+	public function sayHello(array $a): array
+	{
+		$b = array_map(
+			array: $a,
+			callback: static fn(Uuid $c): string => (string) $c,
+		);
+
+		return $b;
+	}
+}