I don't see why we should handle only numeric constant values

Author: staabm

src/Rules/Comparison/SwitchConditionRule.php

@@ -166,28 +166,15 @@ private function isConstantBoolean(Type $type): bool
 	 * A later `case` is a duplicate of an earlier one when both match the exact
 	 * same set of subject values. Besides identical values, `switch` compares
 	 * with loose `==`, so two numerically-equal constants (e.g. 1, '1' and 1.0)
-	 * are duplicates too - they cannot be told apart by a `switch`. Booleans,
-	 * null and non-numeric strings are intentionally left to the strict check
-	 * because their loose-comparison match sets are broader than a single value.
+	 * are duplicates too - they cannot be told apart by a `switch`.
 	 */
 	private function isDuplicateCase(Type $seenType, Type $caseValueType): bool
 	{
 		if ($seenType->equals($caseValueType)) {
 			return true;
 		}
 
-		if (!$this->isNumericConstant($seenType) || !$this->isNumericConstant($caseValueType)) {
-			return false;
-		}
-
 		return $seenType->looseCompare($caseValueType, $this->phpVersion)->isTrue()->yes();
 	}
 
-	private function isNumericConstant(Type $type): bool
-	{
-		return $type->isInteger()->yes()
-			|| $type->isFloat()->yes()
-			|| $type->isNumericString()->yes();
-	}
-
 }

tests/PHPStan/Rules/Comparison/SwitchConditionRuleTest.php

@@ -103,6 +103,14 @@ public function testRule(): void
 				'Case 1.0 in switch is a duplicate of case 1 on line 149.',
 				153,
 			],
+			[
+				'Case true in switch is a duplicate of case 1 on line 149.',
+				155,
+			],
+			[
+				'Case false in switch is a duplicate of case 0 on line 157.',
+				159,
+			],
 		]);
 	}