Resolve __FILE__ and __DIR__ against the trait file in a trait context

Author: zonuexe

src/Reflection/InitializerExprContext.php

@@ -42,8 +42,19 @@ public static function fromScope(Scope $scope): self
 	{
 		$function = $scope->getFunction();
 
+		// __FILE__ and __DIR__ are resolved at compile time, so in a trait context they
+		// point at the file the trait is declared in, while Scope::getFile() returns the
+		// file of the class that uses the trait.
+		$file = $scope->getFile();
+		if ($scope->isInTrait()) {
+			$traitFileName = $scope->getTraitReflection()->getFileName();
+			if ($traitFileName !== null) {
+				$file = $traitFileName;
+			}
+		}
+
 		return new self(
-			$scope->getFile(),
+			$file,
 			$scope->getNamespace(),
 			$scope->isInClass() ? $scope->getClassReflection()->getName() : null,
 			$scope->isInTrait() ? $scope->getTraitReflection()->getName() : null,

tests/PHPStan/Analyser/PathConstantsTest.php

@@ -38,4 +38,11 @@ public static function getAdditionalConfigFiles(): array
 		];
 	}
 
+	protected static function getAdditionalAnalysedFiles(): array
+	{
+		return [
+			__DIR__ . '/data/path-constants-trait/PathConstantsTrait.php',
+		];
+	}
+
 }

tests/PHPStan/Analyser/data/path-constants-trait/PathConstantsTrait.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace PathConstantsTestTrait;
+
+use function PHPStan\Testing\assertType;
+
+trait PathConstantsTrait
+{
+
+	public function doFoo(): void
+	{
+		assertType('\'path-constants-trait\'', substr(__DIR__, -20));
+		assertType('\'PathConstantsTrait.php\'', substr(__FILE__, -22));
+	}
+
+}

tests/PHPStan/Analyser/data/pathConstants-win.php

@@ -4,3 +4,10 @@
 
 \PHPStan\Testing\assertType('\'Analyser\\\\data\'', substr(__DIR__, -13));
 \PHPStan\Testing\assertType('\'pathConstants-win.php\'', substr(__FILE__, -21));
+
+class PathConstantsClassWin
+{
+
+	use \PathConstantsTestTrait\PathConstantsTrait;
+
+}

tests/PHPStan/Analyser/data/pathConstants.php

@@ -4,3 +4,10 @@
 
 \PHPStan\Testing\assertType('\'Analyser/data\'', substr(__DIR__, -13));
 \PHPStan\Testing\assertType('\'pathConstants.php\'', substr(__FILE__, -17));
+
+class PathConstantsClass
+{
+
+	use \PathConstantsTestTrait\PathConstantsTrait;
+
+}