use simpler unit test

Author: staabm

.github/workflows/e2e-tests.yml

@@ -326,7 +326,6 @@ jobs:
               cd e2e/bug-12629
               ../../bin/phpstan --generate-baseline # should generate without crash
               ../../bin/phpstan # should re-analyze without new errors
-              ../bashunit -a assert_files_equals phpstan-baseline.neon phpstan-baseline.neon.expect
 
     steps:
       - name: "Checkout"
@@ -343,8 +342,5 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
-      - name: "Install bashunit"
-        run: "curl -s https://bashunit.typeddevs.com/install.sh | bash -s e2e/ 0.17.0"
-
       - name: "Test"
         run: ${{ matrix.script }}

e2e/bug-12629/phpstan-baseline.neon.expect

@@ -332,4 +332,21 @@ public function dataArrayShapePatterns(): iterable
 		];
 	}
 
+	public function testBug12629(): void
+	{
+		$this->analyse(
+			[__DIR__ . '/data/bug-12629.php'],
+			[
+				[
+					'Regex pattern is invalid: Compilation failed: UTF-8 error: isolated byte with 0x80 bit set at offset 1 in pattern',
+					12,
+				],
+				[
+					'Regex pattern is invalid: Compilation failed: UTF-8 error: byte 2 top bits not 0x80 at offset 0 in pattern',
+					13,
+				],
+			],
+		);
+	}
+
 }

tests/PHPStan/Rules/Regexp/RegularExpressionPatternRuleTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Bug12629b;
+
+class Bug12629 {
+	private function is_macintosh_enc($s) {
+
+		if(!is_string($s)) {
+			return false;
+		}
+
+		preg_match_all("![\x80-\x9f]!u", $s, $matchesMacintosh);
+		preg_match_all("!\xc3[\x80-\x9f]!u", $s, $matchesUtf8);
+
+		return count($matchesMacintosh[0]) > 0 && 0 == count($matchesUtf8[0]);
+	}
+}