RuntimeReflectionFunctionRule: cheap checks first

staabm · staabm · commit f6f59ece732c · 2026-08-10T15:08:22.000+02:00
diff --git a/src/Rules/Api/RuntimeReflectionFunctionRule.php b/src/Rules/Api/RuntimeReflectionFunctionRule.php
@@ -35,6 +35,10 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if (!$scope->isInClass()) {
+			return [];
+		}
+
 		if (!$this->reflectionProvider->hasFunction($node->name, $scope)) {
 			return [];
 		}
@@ -50,10 +54,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$scope->isInClass()) {
-			return [];
-		}
-
 		$classReflection = $scope->getClassReflection();
 		$hasPhpStanInterface = false;
 		foreach (array_keys($classReflection->getInterfaces()) as $interfaceName) {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,10 @@ public function processNode(Node $node, Scope $scope): array`
`35`	`35`	`return [];`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ if (!$scope->isInClass()) {`
	`39`	`+ return [];`
	`40`	`+ }`
	`41`	`+`
`38`	`42`	`if (!$this->reflectionProvider->hasFunction($node->name, $scope)) {`
`39`	`43`	`return [];`
`40`	`44`	`}`
`@@ -50,10 +54,6 @@ public function processNode(Node $node, Scope $scope): array`
`50`	`54`	`return [];`
`51`	`55`	`}`
`52`	`56`
`53`		`- if (!$scope->isInClass()) {`
`54`		`- return [];`
`55`		`- }`
`56`		`-`
`57`	`57`	`$classReflection = $scope->getClassReflection();`
`58`	`58`	`$hasPhpStanInterface = false;`
`59`	`59`	`foreach (array_keys($classReflection->getInterfaces()) as $interfaceName) {`