From 3428bff73729816a24d5a240367a062e6bc7d49a Mon Sep 17 00:00:00 2001
From: Pavel Djundik <xPaw@users.noreply.github.com>
Date: Mon, 2 Dec 2024 21:57:02 +0200
Subject: [PATCH 1/2] Remove incorrect CURLOPT_ACCEPT_ENCODING alias

Fixes https://github.com/phpstan/phpstan/issues/12171
---
 src/Reflection/ParametersAcceptorSelector.php                  | 3 +--
 .../Rules/Functions/CallToFunctionParametersRuleTest.php       | 2 +-
 tests/PHPStan/Rules/Functions/data/curl_setopt.php             | 2 ++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/Reflection/ParametersAcceptorSelector.php b/src/Reflection/ParametersAcceptorSelector.php
index 82af7d4267..703d345806 100644
--- a/src/Reflection/ParametersAcceptorSelector.php
+++ b/src/Reflection/ParametersAcceptorSelector.php
@@ -919,7 +919,6 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 		}
 
 		$nullableStringConstants = [
-			'CURLOPT_ACCEPT_ENCODING',
 			'CURLOPT_CUSTOMREQUEST',
 			'CURLOPT_DNS_INTERFACE',
 			'CURLOPT_DNS_LOCAL_IP4',
@@ -1032,7 +1031,7 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 
 		$stringConstants = [
 			'CURLOPT_COOKIEFILE',
-			'CURLOPT_ENCODING',
+			'CURLOPT_ENCODING', // Alias: CURLOPT_ACCEPT_ENCODING
 			'CURLOPT_PRE_PROXY',
 			'CURLOPT_PRIVATE',
 			'CURLOPT_PROXY',
diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
index af3d4af2c3..97f06b834b 100644
--- a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
+++ b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -1354,7 +1354,7 @@ public function testCurlSetOpt(): void
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array<int, string>, array<string, string> given.',
-				73,
+				75,
 			],
 		]);
 	}
diff --git a/tests/PHPStan/Rules/Functions/data/curl_setopt.php b/tests/PHPStan/Rules/Functions/data/curl_setopt.php
index 24987ddbc9..459645eb20 100644
--- a/tests/PHPStan/Rules/Functions/data/curl_setopt.php
+++ b/tests/PHPStan/Rules/Functions/data/curl_setopt.php
@@ -62,6 +62,8 @@ public function allGood(string $url, array $header) {
 		curl_setopt($curl, CURLOPT_PRE_PROXY, '');
 		curl_setopt($curl, CURLOPT_PROXY, '');
 		curl_setopt($curl, CURLOPT_PRIVATE, '');
+		curl_setopt($curl, CURLOPT_ENCODING, '');
+		curl_setopt($curl, CURLOPT_ACCEPT_ENCODING, '');
 	}
 
 	public function bug9263() {

From 64803ee6255e1d54b3e2627398936710da92f8cd Mon Sep 17 00:00:00 2001
From: Pavel Djundik <xPaw@users.noreply.github.com>
Date: Mon, 2 Dec 2024 22:44:44 +0200
Subject: [PATCH 2/2] Add test

---
 .../CallToFunctionParametersRuleTest.php      | 26 ++++++++++++-------
 .../Rules/Functions/data/curl_setopt.php      |  2 ++
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
index 97f06b834b..89017fe2cf 100644
--- a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
+++ b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -1321,40 +1321,48 @@ public function testCurlSetOpt(): void
 				18,
 			],
 			[
-				'Parameter #3 $value of function curl_setopt expects bool, int given.',
+				'Parameter #3 $value of function curl_setopt expects string, int given.',
+				19,
+			],
+			[
+				'Parameter #3 $value of function curl_setopt expects string, int given.',
 				20,
 			],
+			[
+				'Parameter #3 $value of function curl_setopt expects bool, int given.',
+				22,
+			],
 			[
 				'Parameter #3 $value of function curl_setopt expects bool, string given.',
-				21,
+				23,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects int, string given.',
-				23,
+				25,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array, string given.',
-				25,
+				27,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects resource, string given.',
-				27,
+				29,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array|string, int given.',
-				29,
+				31,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects non-empty-string, \'\' given.',
-				31,
+				33,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects non-empty-string|null, \'\' given.',
-				32,
+				34,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array<int, string>, array<string, string> given.',
-				75,
+				77,
 			],
 		]);
 	}
diff --git a/tests/PHPStan/Rules/Functions/data/curl_setopt.php b/tests/PHPStan/Rules/Functions/data/curl_setopt.php
index 459645eb20..bc5b8f6cea 100644
--- a/tests/PHPStan/Rules/Functions/data/curl_setopt.php
+++ b/tests/PHPStan/Rules/Functions/data/curl_setopt.php
@@ -16,6 +16,8 @@ public function errors(int $i, string $s) {
 		curl_setopt($curl, CURLOPT_URL, $i);
 		curl_setopt($curl, CURLOPT_HTTPHEADER, $i);
 		curl_setopt($curl, CURLOPT_ABSTRACT_UNIX_SOCKET, null);
+		curl_setopt($curl, CURLOPT_ENCODING, $i);
+		curl_setopt($curl, CURLOPT_ACCEPT_ENCODING, $i);
 		// expecting bool
 		curl_setopt($curl, CURLOPT_AUTOREFERER, $i);
 		curl_setopt($curl, CURLOPT_RETURNTRANSFER, $s);