lake: incremental updates 0531#22968
Conversation
lilin90
added
translation/no-need
ti-chi-bot
Bot
added
the
size/XXL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive documentation for Amazon SQS (S3) integration, including new guides for the SQS (S3) IAM Role data source and integration tasks, as well as a detailed guide on Data Protection Policies (masking and row access policies). It also updates several SQL reference files and guides to clarify regular expression pattern matching for staged files. The review feedback highlights opportunities to better align with the style guide by rewriting passive voice sentences into the active voice, addressing the user in the second person ('you'), applying sentence case to headings, and consistently formatting function names, keywords, and paths with backticks.
Replace instances of 'AWS - Credentials' with 'Amazon S3 - Credentials' in tidb-cloud-lake/guides/integrate-with-amazon-s3.md to clarify the credential type; updates link text and data source field descriptions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Update the Amazon SQS + S3 IAM role guide to use 'platform' naming instead of 'databend'. Changes include env var renames (ROLE_NAME, PLATFORM_SETUP_ROLE_ARN, PLATFORM_LOAD_ROLE_ARN, EXTERNAL_ID), updated guidance text, trust-policy jq variable names and Statement Sids, IAM policy name (platform-s3-sqs-access), and example test filenames/object keys. This clarifies that the roles and ARNs are provided by Platform and keeps naming consistent across the doc.
Add missing blank lines to improve readability in two documentation pages: tidb-cloud-lake/guides/row-access-policy.md (under 'Test with multiple roles') and tidb-cloud-lake/sql/system-history-tables.md (under 'Required Permissions'). No substantive content changes; only whitespace/formatting adjustments.
Update the link in tidb-cloud-lake/guides/integrate-with-amazon-sqs-s3.md from a relative path ('./integrate-with-amazon-s3.md') to an absolute path ('/tidb-cloud-lake/guides/integrate-with-amazon-s3.md') to ensure correct navigation and consistent linking across the site.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
merged commit b1bdc6b
into
pingcap:feature/preview-cloud-lake
1 participant
What is changed, added or deleted? (Required)
Incremental updates till 05/31/2026
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?