FIX: return type in IsoCodesValidationServiceProvider::getTranslationKeyFromMethodName()

pixelpeter · pixelpeter · commit d113ff8ee71c · 2025-04-01T17:37:20.000+02:00
diff --git a/src/IsoCodesValidationServiceProvider.php b/src/IsoCodesValidationServiceProvider.php
@@ -37,14 +37,15 @@ public function boot()
      * Return translation key for correspondent method name
      *
      * @param  string  $name
-     * @return string
+     * @return string | boolean
      */
     private function getTranslationKeyFromMethodName($name)
     {
-        if (stripos($name, 'validate') !== false) {
-            return Str::snake(substr($name, 8));
+        if (stripos($name, 'validate') === false) {
+            return false;
         }
 
+        return Str::snake(substr($name, 8));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -37,14 +37,15 @@ public function boot()`
`37`	`37`	`* Return translation key for correspondent method name`
`38`	`38`	`*`
`39`	`39`	`* @param string $name`
`40`		`- * @return string`
	`40`	`+ * @return string \| boolean`
`41`	`41`	`*/`
`42`	`42`	`private function getTranslationKeyFromMethodName($name)`
`43`	`43`	`{`
`44`		`- if (stripos($name, 'validate') !== false) {`
`45`		`- return Str::snake(substr($name, 8));`
	`44`	`+ if (stripos($name, 'validate') === false) {`
	`45`	`+ return false;`
`46`	`46`	`}`
`47`	`47`
	`48`	`+ return Str::snake(substr($name, 8));`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`/**`