Skip to content

Commit 5cedd07

Browse files
committed
Fix bpf tests
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent 07f9f40 commit 5cedd07

File tree

2 files changed

+18
-25
lines changed

2 files changed

+18
-25
lines changed

src/stirling/source_connectors/socket_tracer/go_tls_trace_bpf_test.cc

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -114,28 +114,26 @@ struct Go1_22TLSClientServerContainers {
114114
static constexpr std::string_view server_image_tar = GoTLSServerContainer::kBazelImageTar;
115115
static const bool disable_dwarf = false;
116116
};
117-
118-
struct Go1_23TLSClientServerContainers {
119-
using GoTLSServerContainer = ::px::stirling::testing::Go1_23_TLSServerContainer;
120-
using GoTLSClientContainer = ::px::stirling::testing::Go1_23_TLSClientContainer;
117+
struct Go1_22TLSClientServerContainersNoDWARFContainers {
118+
using GoTLSClientContainer = ::px::stirling::testing::Go1_24_TLSClientContainer;
119+
using GoTLSClientContainer = ::px::stirling::testing::Go1_22_TLSClientContainer;
121120

122121
static constexpr std::string_view server_image_tar = GoTLSServerContainer::kBazelImageTar;
123-
static const bool disable_dwarf = false;
122+
static const bool disable_dwarf = true;
124123
};
125124

126-
struct Go1_23TLSClientServerNoDWARFContainers {
125+
struct Go1_23TLSClientServerContainers {
127126
using GoTLSServerContainer = ::px::stirling::testing::Go1_23_TLSServerContainer;
128127
using GoTLSClientContainer = ::px::stirling::testing::Go1_23_TLSClientContainer;
129128

130-
static constexpr std::string_view server_image_tar =
131-
"src/stirling/source_connectors/socket_tracer/testing/containers/"
132-
"golang_1_23_0_https_server_with_buildinfo.tar";
133-
static const bool disable_dwarf = true;
129+
static constexpr std::string_view server_image_tar = GoTLSServerContainer::kBazelImageTar;
130+
static const bool disable_dwarf = false;
134131
};
135132

136133
struct Go1_24TLSClientServerContainers {
137134
using GoTLSServerContainer = ::px::stirling::testing::Go1_24_TLSServerContainer;
138135
using GoTLSClientContainer = ::px::stirling::testing::Go1_24_TLSClientContainer;
136+
static const bool disable_dwarf = false;
139137
};
140138

141139
struct GoBoringCryptoTLSClientServerContainers {
@@ -149,7 +147,7 @@ struct GoBoringCryptoTLSClientServerContainers {
149147
typedef ::testing::Types<GoBoringCryptoTLSClientServerContainers, Go1_18TLSClientServerContainers,
150148
Go1_19TLSClientServerContainers, Go1_20TLSClientServerContainers,
151149
Go1_21TLSClientServerContainers, Go1_22TLSClientServerContainers,
152-
Go1_23TLSClientServerContainers, Go1_23TLSClientServerNoDWARFContainers,
150+
Go1_23TLSClientServerContainers, Go1_22TLSClientServerNoDWARFContainers,
153151
Go1_24TLSClientServerContainers>
154152
GoVersions;
155153
TYPED_TEST_SUITE(GoTLSTraceTest, GoVersions);

src/stirling/source_connectors/socket_tracer/http2_trace_bpf_test.cc

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -118,27 +118,26 @@ struct Go1_22GRPCClientServerContainers {
118118
static const bool disable_dwarf = false;
119119
};
120120

121-
struct Go1_23GRPCClientServerContainers {
122-
using ServerContainer = ::px::stirling::testing::Go1_23_GRPCServerContainer;
123-
using ClientContainer = ::px::stirling::testing::Go1_23_GRPCClientContainer;
121+
struct Go1_22GRPCClientServerContainersNoDWARF {
122+
using ServerContainer = ::px::stirling::testing::Go1_22_GRPCServerContainer;
123+
using ClientContainer = ::px::stirling::testing::Go1_24_GRPCClientContainer;
124124

125125
static constexpr std::string_view server_image_tar = ServerContainer::kBazelImageTar;
126-
static const bool disable_dwarf = false;
126+
static const bool disable_dwarf = true;
127127
};
128128

129-
struct Go1_23GRPCClientServerContainersNoDWARF {
129+
struct Go1_23GRPCClientServerContainers {
130130
using ServerContainer = ::px::stirling::testing::Go1_23_GRPCServerContainer;
131131
using ClientContainer = ::px::stirling::testing::Go1_23_GRPCClientContainer;
132132

133-
static constexpr std::string_view server_image_tar =
134-
"src/stirling/source_connectors/socket_tracer/testing/containers/"
135-
"go_1_23_grpc_server_with_mod_info.tar";
136-
static const bool disable_dwarf = true;
133+
static constexpr std::string_view server_image_tar = ServerContainer::kBazelImageTar;
134+
static const bool disable_dwarf = false;
137135
};
138136

139137
struct Go1_24GRPCClientServerContainers {
140138
using ServerContainer = ::px::stirling::testing::Go1_24_GRPCServerContainer;
141139
using ClientContainer = ::px::stirling::testing::Go1_24_GRPCClientContainer;
140+
static const bool disable_dwarf = false;
142141
};
143142

144143
struct GoBoringCryptoGRPCClientServerContainers {
@@ -152,12 +151,8 @@ struct GoBoringCryptoGRPCClientServerContainers {
152151
typedef ::testing::Types<GoBoringCryptoGRPCClientServerContainers, Go1_18GRPCClientServerContainers,
153152
Go1_19GRPCClientServerContainers, Go1_20GRPCClientServerContainers,
154153
Go1_21GRPCClientServerContainers, Go1_22GRPCClientServerContainers,
155-
<<<<<<< HEAD
156154
Go1_23GRPCClientServerContainers, Go1_24GRPCClientServerContainers>
157-
=======
158-
Go1_23GRPCClientServerContainers, Go1_23GRPCClientServerContainersNoDWARF>
159-
>>>>>>> 345dddc7b (Include offsetgen case in http2_trace_bpf_test)
160-
GoVersions;
155+
Go1_23GRPCClientServerContainers, Go1_22GRPCClientServerContainersNoDWARF > GoVersions;
161156
TYPED_TEST_SUITE(HTTP2TraceTest, GoVersions);
162157

163158
TYPED_TEST(HTTP2TraceTest, Basic) {

0 commit comments

Comments
 (0)