Convert rejected strings to the error objects

Author: ivankravets

src/core.js

@@ -62,7 +62,7 @@ export function getVersion() {
             return reject(err.toString());
           }
         }
-        return reject(stderr);
+        return reject(new Error(stderr));
       }
     );
   });

src/home.js

@@ -143,15 +143,15 @@ async function _ensureServerStarted(options={}) {
         (code, stdout, stderr) => {
           if (code !== 0) {
             HTTP_PORT = 0;
-            return reject(stderr);
+            return reject(new Error(stderr));
           }
         }
       );
       tcpPortUsed.waitUntilUsed(HTTP_PORT, 500, SERVER_LAUNCH_TIMEOUT * 1000)
         .then(() => {
           resolve(true);
         }, (err) => {
-          reject('Could not start PIO Home server: ' + err.toString());
+          reject(new Error('Could not start PIO Home server: ' + err.toString()));
         });
     });
   }

src/installer/stages/platformio-core.js

@@ -110,7 +110,7 @@ export default class PlatformIOCoreStage extends BaseStage {
             if (fs.isFileSync(logFile)) {
               stderr = fs.readFileSync(logFile).toString();
             }
-            return reject(`MSI Python2.7: ${stderr}`);
+            return reject(new Error(`MSI Python2.7: ${stderr}`));
           }
         },
         {
@@ -155,7 +155,7 @@ export default class PlatformIOCoreStage extends BaseStage {
           if (code === 0) {
             return resolve(stdout);
           } else {
-            return reject(`Conda Virtualenv: ${stderr}`);
+            return reject(new Error(`Conda Virtualenv: ${stderr}`));
           }
         }
       );
@@ -174,7 +174,7 @@ export default class PlatformIOCoreStage extends BaseStage {
             if (code === 0) {
               return resolve(stdout);
             } else {
-              return reject(`User's Virtualenv: ${stderr}`);
+              return reject(new Error(`User's Virtualenv: ${stderr}`));
             }
           }
         );
@@ -189,7 +189,7 @@ export default class PlatformIOCoreStage extends BaseStage {
             if (code === 0) {
               return resolve(stdout);
             } else {
-              return reject(`User's Virtualenv: ${stderr}`);
+              return reject(new Error(`User's Virtualenv: ${stderr}`));
             }
           }
         );
@@ -231,7 +231,7 @@ export default class PlatformIOCoreStage extends BaseStage {
             if (stderr.includes('WindowsError: [Error 5]')) {
               userNotification = `If you use Antivirus, it can block PlatformIO Installer. Try to disable it for a while.\n\n${userNotification}`;
             }
-            return reject(userNotification);
+            return reject(new Error(userNotification));
           }
         }
       );
@@ -247,7 +247,7 @@ export default class PlatformIOCoreStage extends BaseStage {
           if (code === 0) {
             return resolve(stdout);
           } else {
-            return reject(`Install Virtualenv globally: ${stderr}`);
+            return reject(new Error(`Install Virtualenv globally: ${stderr}`));
           }
         }
       );
@@ -262,6 +262,7 @@ export default class PlatformIOCoreStage extends BaseStage {
     try {
       await this.createVirtualenvWithLocal(pythonExecutable);
     } catch (err) {
+      misc.reportError(err);
       console.warn(err);
       try {
         await this.createVirtualenvWithDownload(pythonExecutable);
@@ -317,7 +318,7 @@ export default class PlatformIOCoreStage extends BaseStage {
           if (misc.IS_WINDOWS) {
             stderr += '\n If you have antivirus software in a system, try to disable it for a while.';
           }
-          reject(`PIP: ${stderr}`);
+          reject(new Error(`PIP: ${stderr}`));
         }
       });
     });

src/misc.js

@@ -228,6 +228,6 @@ export function reportError(err, tags=undefined) {
   Sentry.withScope(scope => {
     Object.entries(tags || {}).forEach(([key, value]) => scope.setTag(key, value));
     scope.setTag('caller', process.env.PLATFORMIO_CALLER);
-    Sentry.captureException(err);
+    Sentry.captureException(err instanceof Error ? err : new Error(err));
   });  
 }

src/project/indexer.js

@@ -48,7 +48,7 @@ import { runPIOCommand }  from '../core';
               if (code === 0) {
                 resolve();
               } else {
-                reject(stderr);
+                reject(new Error(stderr));
               }
             });
           });
@@ -122,7 +122,7 @@ import { runPIOCommand }  from '../core';
             if (code === 0) {
               resolve(stdout.toString().trim().split(':'));
             } else {
-              reject(stderr);
+              reject(new Error(stderr));
             }
           },
           {