fix: ENVIRONMENT_TYPE needs to be used to check onProduction()

Author: matthiaz

src/Config.php

@@ -35,6 +35,8 @@
  *   The Git branch name.
  * @property-read string $environment
  *   The environment ID (usually the Git branch plus a hash).
+ * @property-read string $environmentType
+ *   The environmentType (prod, staging, dev)
  * @property-read string $documentRoot
  *   The absolute path to the web root of the application.
  * @property-read string $smtpHost
@@ -76,6 +78,7 @@ class Config
     protected $directVariablesRuntime = [
         'branch' => 'BRANCH',
         'environment' => 'ENVIRONMENT',
+        'environmentType' => 'ENVIRONMENT_TYPE',
         'documentRoot' => 'DOCUMENT_ROOT',
         'smtpHost' => 'SMTP_HOST',
     ];
@@ -437,9 +440,20 @@ public function onProduction() : bool
             return false;
         }
 
-        $prodBranch = $this->onDedicated() ? 'production' : 'master';
-
-        return $this->getValue('BRANCH') == $prodBranch;
+        // we need to first confirm that we actually have the `ENVIRONMENT_TYPE` variable, 
+        // because not all legacy containers will have this
+        print_r(array_keys($this->environmentVariables));
+        if($this->hasVariable('ENVIRONMENT_TYPE')) {
+            // correct way of checking production branch
+            echo 'new';
+            
+            return $this->getValue('ENVIRONMENT_TYPE') == 'production';
+        } else {
+            echo "legacy";
+            // legacy way of checking production type
+            $prodBranch = $this->onDedicated() ? 'production' : 'master';
+            return $this->getValue('BRANCH') == $prodBranch;
+        }
     }
 
     /**
@@ -498,6 +512,17 @@ public function hasRelationship(string $relationship) : bool
         return isset($this->relationshipsDef[$relationship]);
     }
 
+    /**
+     * Check if an environment variable exists, useful for backwards compatibility checks
+     *
+     * @param string $name
+     *   The env variable to check.
+     * @return bool
+     */
+    protected function hasVariable(string $name) :?bool
+    {
+        return array_key_exists($name, $this->environmentVariables);
+    }
     /**
      * Reads an environment variable, taking the prefix into account.
      *

tests/ConfigTest.php

@@ -200,6 +200,27 @@ public function test_ondedicated_returns_false_on_standard() : void
         $this->assertFalse($config->onDedicated());
     }
 
+    public function test_onproduction_prod_is_true() : void
+    {
+        echo 'test_onproduction_prod_is_true';
+        
+        $env = $this->mockEnvironmentDeploy;
+        $env['PLATFORM_ENVIRONMENT_TYPE'] = 'production';
+        $config = new Config($env);
+
+        $this->assertTrue($config->onProduction());
+    }
+
+    public function test_onproduction_stg_is_false() : void
+    {
+        echo 'test_onproduction_stg_is_false';
+        $env = $this->mockEnvironmentDeploy;
+        $env['PLATFORM_ENVIRONMENT_TYPE'] = 'staging';
+        $config = new Config($env);
+
+        $this->assertFalse($config->onProduction());
+    }
+
     public function test_onproduction_on_dedicated_prod_is_true() : void
     {
         $env = $this->mockEnvironmentDeploy;