Commit 554f660
fix(indicator): use common::Ticks for GaugeAxis to allow disabling ticks
gauge.axis.ticks accepts "outside", "inside", or "" (disabled). TicksDirection
only covers inside/outside, so "no ticks" was inexpressible. Switch to
common::Ticks (Outside/Inside/None -> "outside"/"inside"/"") and add a test that
Ticks::None serializes to "".
Addresses roborev review job 3599 (the tickmode finding in that review was a
false positive: the v3.7.0 schema lists gauge.axis.tickmode as
["auto","linear","array"], so TickMode::Auto is valid).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent ef4cbca commit 554f660
1 file changed
Lines changed: 13 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | | - | |
189 | | - | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
| |||
587 | 588 | | |
588 | 589 | | |
589 | 590 | | |
590 | | - | |
| 591 | + | |
591 | 592 | | |
592 | 593 | | |
593 | 594 | | |
| |||
651 | 652 | | |
652 | 653 | | |
653 | 654 | | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
654 | 662 | | |
655 | 663 | | |
656 | 664 | | |
| |||
0 commit comments