Skip to content

Commit e38d38a

Browse files
committed
fix EMSDK_PYTHON
1 parent 4ce6c37 commit e38d38a

File tree

2 files changed

+20
-31
lines changed

2 files changed

+20
-31
lines changed

config

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,26 @@ export PYTHONDONTWRITEBYTECODE=1
77
export REBUILD=${REBUILD:-false}
88
export CI=${CI:-false}
99

10-
export PYBUILD=${PYBUILD:-3.11}
10+
export PYMAJOR=3
11+
export PYBUILD=${PYBUILD:-${PYMAJOR}.11}
1112

1213
export HOST_PREFIX=${HOST_PREFIX:-${SDKROOT}/devices/$(arch)/usr}
1314
export PREFIX=${PREFIX:-${SDKROOT}/devices/emsdk/usr}
1415
export PYTHONPYCACHEPREFIX=$(realpath ${SDKROOT}/build/pycache)
1516

16-
export PYMAJOR=3
17+
18+
# this is python used for emsdk : ${SYS_PYTHON} -> ${EMSDK_PYTHON}
19+
for py in 10 9 8 7
20+
do
21+
if command -v python${PYMAJOR}.${py} >/dev/null
22+
then
23+
export SYS_PYTHON=$(command -v python${PYMAJOR}.${py})
24+
break
25+
else
26+
# sane default
27+
export SYS_PYTHON=$(command -v python${PYMAJOR})
28+
fi
29+
done
1730

1831
export HPY=${HOST_PREFIX}/bin/python${PYBUILD}
1932

@@ -30,17 +43,6 @@ then
3043
export PIP=${HOST_PREFIX}/bin/pip3.${PYMINOR}
3144
fi
3245

33-
# this is python used for emsdk : ${SYS_PYTHON} -> ${EMSDK_PYTHON}
34-
for py in 10 9 8 7
35-
do
36-
if command -v python3.${py} >/dev/null
37-
then
38-
export SYS_PYTHON=$(command -v python3.${py})
39-
break
40-
fi
41-
done
42-
43-
4446
# cpython build opts
4547
export CPOPTS="-Os -g0 -fPIC"
4648
export CPPFLAGS="-I$PREFIX/include"

scripts/emsdk-fetch.sh

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ then
3232
* activating emsdk via emsdk_env.sh
3333
"
3434
. emsdk/emsdk_env.sh 2>&1 > /dev/null
35+
# EMSDK_PYTHON may be cleared, restore it
3536
export EMSDK_PYTHON=$SYS_PYTHON
3637
else
3738
echo "
@@ -40,20 +41,6 @@ then
4041
exit 1
4142
fi
4243

43-
# EMSDK_PYTHON is cleared
44-
# https://github.com/emscripten-core/emscripten/pull/16736
45-
# # 3.6 could have problems
46-
# for py in 10 9 8 7
47-
# do
48-
# if command -v python3.${py} >/dev/null
49-
# then
50-
# export EMSDK_PYTHON=$(command -v python3.${py})
51-
# break
52-
# fi
53-
# done
54-
55-
56-
5744
if [ -f embuild.done ]
5845
then
5946
echo "
@@ -135,9 +122,9 @@ done
135122
136123
if \$IS_SHARED
137124
then
138-
\$EMSDK_PYTHON -E \$0.py $SHARED $LDFLAGS "\$@" $COMMON
125+
$EMSDK_PYTHON -E \$0.py $SHARED $LDFLAGS "\$@" $COMMON
139126
else
140-
\$EMSDK_PYTHON -E \$0.py $CPPFLAGS "\$@" $COMMON
127+
$EMSDK_PYTHON -E \$0.py $CPPFLAGS "\$@" $COMMON
141128
fi
142129
END
143130
cat emsdk/upstream/emscripten/emcc > emsdk/upstream/emscripten/em++
@@ -149,14 +136,14 @@ unset _PYTHON_SYSCONFIGDATA_NAME
149136
unset PYTHONHOME
150137
unset PYTHONPATH
151138
152-
\$EMSDK_PYTHON -E \$0.py "\$@"
139+
$EMSDK_PYTHON -E \$0.py "\$@"
153140
END
154141

155142
cat emsdk/upstream/emscripten/emar > emsdk/upstream/emscripten/emcmake
156143

157144
cat > emsdk/upstream/emscripten/emconfigure <<END
158145
#!/bin/bash
159-
\$EMSDK_PYTHON -E \$0.py "\$@"
146+
$EMSDK_PYTHON -E \$0.py "\$@"
160147
END
161148

162149
chmod +x emsdk/upstream/emscripten/em*

0 commit comments

Comments
 (0)