Avoid extra metadatabase directory setup

Author: byMohamedali

Sources/SQLiteData/CloudKit/Internal/Metadatabase.swift

@@ -13,13 +13,6 @@
       open "\(url.path(percentEncoded: false))"
       """
     )
-    if !url.isInMemory {
-      try FileManager.default.createDirectory(
-        at: url.deletingLastPathComponent(),
-        withIntermediateDirectories: true
-      )
-    }
-
     @Dependency(\.context) var context
     guard !url.isInMemory || context != .live
     else {

Sources/SQLiteData/CloudKit/SyncEngine.swift

@@ -75,8 +75,6 @@
     ///     you do not want to be shareable with other users.
     ///   - containerIdentifier: The container identifier in CloudKit to synchronize to. If omitted
     ///     the container will be determined from the entitlements of your app.
-    ///   - metadatabaseURL: The location of the metadata database used to track CloudKit sync
-    ///     state. If omitted, a default location is derived from the main database path.
     ///   - defaultZone: The zone for all records to be stored in.
     ///   - startImmediately: Determines if the sync engine starts right away or requires an
     ///     explicit call to ``start()``. By default this argument is `true`.
@@ -92,7 +90,6 @@
       tables: repeat (each T1).Type,
       privateTables: repeat (each T2).Type,
       containerIdentifier: String? = nil,
-      metadatabaseURL: URL? = nil,
       defaultZone: CKRecordZone = CKRecordZone(zoneName: "co.pointfree.SQLiteData.defaultZone"),
       startImmediately: Bool? = nil,
       delegate: (any SyncEngineDelegate)? = nil,
@@ -149,7 +146,6 @@
             )
           },
           userDatabase: userDatabase,
-          metadatabaseURL: metadatabaseURL,
           logger: logger,
           delegate: delegate,
           tables: allTables,
@@ -199,7 +195,6 @@
           )
         },
         userDatabase: userDatabase,
-        metadatabaseURL: metadatabaseURL,
         logger: logger,
         delegate: delegate,
         tables: allTables,
@@ -220,7 +215,6 @@
           SyncEngine
         ) -> (private: any SyncEngineProtocol, shared: any SyncEngineProtocol),
       userDatabase: UserDatabase,
-      metadatabaseURL: URL? = nil,
       logger: Logger,
       delegate: (any SyncEngineDelegate)?,
       tables: [any SynchronizableTable],
@@ -264,15 +258,12 @@
       self.defaultSyncEngines = defaultSyncEngines
       self.userDatabase = userDatabase
       self.logger = logger
-      let resolvedMetadatabaseURL =
-        try metadatabaseURL
-        ?? URL.metadatabase(
+      self.metadatabase = try defaultMetadatabase(
+        logger: logger,
+        url: try URL.metadatabase(
           databasePath: userDatabase.path,
           containerIdentifier: container.containerIdentifier
         )
-      self.metadatabase = try defaultMetadatabase(
-        logger: logger,
-        url: resolvedMetadatabaseURL
       )
       self.tablesByName = Dictionary(
         uniqueKeysWithValues: self.tables.map { ($0.base.tableName, $0) }
@@ -2220,15 +2211,9 @@
     ///
     /// See <doc:PreparingDatabase> for more information on preparing your database.
     ///
-    /// - Parameters:
-    ///   - containerIdentifier: The identifier of the CloudKit container used to
-    ///     synchronize data. Defaults to the value set in the app's entitlements.
-    ///   - metadatabaseURL: The location of the attached metadata database. If omitted, a default
-    ///     location is derived from the main database path.
-    public func attachMetadatabase(
-      containerIdentifier: String? = nil,
-      metadatabaseURL: URL? = nil
-    ) throws {
+    /// - Parameter containerIdentifier: The identifier of the CloudKit container used to
+    /// synchronize data. Defaults to the value set in the app's entitlements.
+    public func attachMetadatabase(containerIdentifier: String? = nil) throws {
       @Dependency(\.context) var context
       let containerIdentifier =
         containerIdentifier
@@ -2249,18 +2234,11 @@
             """
         )
       }
-      let url = try metadatabaseURL
-        ?? URL.metadatabase(
-          databasePath: databasePath,
-          containerIdentifier: containerIdentifier
-        )
+      let url = try URL.metadatabase(
+        databasePath: databasePath,
+        containerIdentifier: containerIdentifier
+      )
       let path = url.isInMemory ? url.absoluteString : url.path(percentEncoded: false)
-      if !url.isInMemory {
-        try FileManager.default.createDirectory(
-          at: url.deletingLastPathComponent(),
-          withIntermediateDirectories: true
-        )
-      }
       let database: any DatabaseWriter =
         url.isInMemory
         ? try DatabaseQueue(path: path)