From f9cfbaf0c99616ef1bf51c148ae94d791d87e51c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tau=20G=C3=A4rtli?= Date: Tue, 21 Jan 2025 12:12:09 +0100 Subject: [PATCH 1/6] Migrate to Polyadic.CodeStyle --- Directory.Build.props | 2 +- Directory.Packages.props | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index f7d55bc..7c36f8b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -7,7 +7,7 @@ https://github.com/polyadic/funcky-efcore - + diff --git a/Directory.Packages.props b/Directory.Packages.props index 1cda610..011f8b9 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -9,7 +9,7 @@ - + From 9351bc94ac346d182efc9583696136a9758c24f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tau=20G=C3=A4rtli?= Date: Tue, 21 Jan 2025 12:13:15 +0100 Subject: [PATCH 2/6] Enable package validation --- Funcky.EntityFrameworkCore/Funcky.EntityFrameworkCore.csproj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Funcky.EntityFrameworkCore/Funcky.EntityFrameworkCore.csproj b/Funcky.EntityFrameworkCore/Funcky.EntityFrameworkCore.csproj index 436afe7..a4ad29f 100644 --- a/Funcky.EntityFrameworkCore/Funcky.EntityFrameworkCore.csproj +++ b/Funcky.EntityFrameworkCore/Funcky.EntityFrameworkCore.csproj @@ -8,6 +8,7 @@ Interoperability between Funcky and EF Core Functional Monad EFCore EntityFramework 1.3.0 + 1.0.0 readme.md @@ -18,6 +19,7 @@ true All + true From 35f62231c7aff9b677475e5314b1e00949d381ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tau=20G=C3=A4rtli?= Date: Tue, 21 Jan 2025 12:17:41 +0100 Subject: [PATCH 3/6] Use a central artifacts directory --- Directory.Build.props | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Directory.Build.props b/Directory.Build.props index 7c36f8b..23029ab 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -19,4 +19,7 @@ true true + + $(MSBuildThisFileDirectory)artifacts + From ab98ca4eb7c508c06071795316f990e97da98aa3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tau=20G=C3=A4rtli?= Date: Tue, 21 Jan 2025 12:18:00 +0100 Subject: [PATCH 4/6] Move APIs to shipped --- Funcky.EntityFrameworkCore/PublicAPI.Shipped.txt | 7 +++++++ Funcky.EntityFrameworkCore/PublicAPI.Unshipped.txt | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Funcky.EntityFrameworkCore/PublicAPI.Shipped.txt b/Funcky.EntityFrameworkCore/PublicAPI.Shipped.txt index ab058de..25760c0 100644 --- a/Funcky.EntityFrameworkCore/PublicAPI.Shipped.txt +++ b/Funcky.EntityFrameworkCore/PublicAPI.Shipped.txt @@ -1 +1,8 @@ #nullable enable +Funcky.Extensions.EntityFrameworkQueryableExtensions +static Funcky.Extensions.EntityFrameworkQueryableExtensions.FirstOrNoneAsync(this System.Linq.IQueryable! source, System.Linq.Expressions.Expression!>! predicate, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! +static Funcky.Extensions.EntityFrameworkQueryableExtensions.FirstOrNoneAsync(this System.Linq.IQueryable! source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! +static Funcky.Extensions.EntityFrameworkQueryableExtensions.LastOrNoneAsync(this System.Linq.IQueryable! source, System.Linq.Expressions.Expression!>! predicate, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! +static Funcky.Extensions.EntityFrameworkQueryableExtensions.LastOrNoneAsync(this System.Linq.IQueryable! source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! +static Funcky.Extensions.EntityFrameworkQueryableExtensions.SingleOrNoneAsync(this System.Linq.IQueryable! source, System.Linq.Expressions.Expression!>! predicate, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! +static Funcky.Extensions.EntityFrameworkQueryableExtensions.SingleOrNoneAsync(this System.Linq.IQueryable! source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! diff --git a/Funcky.EntityFrameworkCore/PublicAPI.Unshipped.txt b/Funcky.EntityFrameworkCore/PublicAPI.Unshipped.txt index 25760c0..ab058de 100644 --- a/Funcky.EntityFrameworkCore/PublicAPI.Unshipped.txt +++ b/Funcky.EntityFrameworkCore/PublicAPI.Unshipped.txt @@ -1,8 +1 @@ #nullable enable -Funcky.Extensions.EntityFrameworkQueryableExtensions -static Funcky.Extensions.EntityFrameworkQueryableExtensions.FirstOrNoneAsync(this System.Linq.IQueryable! source, System.Linq.Expressions.Expression!>! predicate, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! -static Funcky.Extensions.EntityFrameworkQueryableExtensions.FirstOrNoneAsync(this System.Linq.IQueryable! source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! -static Funcky.Extensions.EntityFrameworkQueryableExtensions.LastOrNoneAsync(this System.Linq.IQueryable! source, System.Linq.Expressions.Expression!>! predicate, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! -static Funcky.Extensions.EntityFrameworkQueryableExtensions.LastOrNoneAsync(this System.Linq.IQueryable! source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! -static Funcky.Extensions.EntityFrameworkQueryableExtensions.SingleOrNoneAsync(this System.Linq.IQueryable! source, System.Linq.Expressions.Expression!>! predicate, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! -static Funcky.Extensions.EntityFrameworkQueryableExtensions.SingleOrNoneAsync(this System.Linq.IQueryable! source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task>! From 1609853d06178870b9bd8260f1518d8fe6df2cf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tau=20G=C3=A4rtli?= Date: Tue, 21 Jan 2025 12:20:16 +0100 Subject: [PATCH 5/6] Update actions --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 91bc686..b2ae0d3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,8 +18,8 @@ jobs: env: EntityFrameworkCoreVersion: ${{matrix.efcore}} steps: - - uses: actions/checkout@v2 - - uses: actions/setup-dotnet@v1 + - uses: actions/checkout@v4 + - uses: actions/setup-dotnet@v4 - name: Restore dependencies run: dotnet restore - name: Build @@ -30,8 +30,8 @@ jobs: nupkg: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-dotnet@v1 + - uses: actions/checkout@v4 + - uses: actions/setup-dotnet@v4 - name: Generate NuGet Packages run: dotnet pack --configuration Release --output nupkg - uses: actions/upload-artifact@v4 From 23747325fc8ec87b49750e72deb828813a0cb372 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tau=20G=C3=A4rtli?= Date: Tue, 21 Jan 2025 12:20:28 +0100 Subject: [PATCH 6/6] Treat warnings as errors everywhere --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b2ae0d3..94bf411 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -2,6 +2,7 @@ name: Build env: DOTNET_NOLOGO: 1 + TreatWarningsAsErrors: true on: push: @@ -23,7 +24,7 @@ jobs: - name: Restore dependencies run: dotnet restore - name: Build - run: dotnet build --configuration Release --no-restore /p:TreatWarningsAsErrors=true + run: dotnet build --configuration Release --no-restore - name: Run Tests run: dotnet test --configuration Release --no-build