Skip to content

Create unit tests for providers #493

@eloekset

Description

@eloekset

Is your feature request related to a problem? Please describe.
In #492 I suspected a bug in the implementation of DeleteTxtRecordAsync for the DomeneShopProvider.

Describe the solution you'd like
To verify the bug existed and was fixed, I created a unit test project and implemented tests for all the public methods of DomeneShopProvider. Consider implementing tests for the other existing providers to verify the functionality and better describe the provider for developers without access to that provider's API.

Describe alternatives you've considered

  • Implement changes and deploy a pre-release to test and verify functionality live against the provider's API.
  • Create another test project for integration tests with sample data that verifies functionality all the way from the AcmeBot for each provider. This requires a configuration with credentials that should be gitignored and the tests must be easily modified with sample data that suits a developers own domain.

Additional context
The tests I've implemented will be sent in a separate PR.
image

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions