Please eslint

Please eslint

Author: porsager

lib/frontend.js

@@ -84,7 +84,7 @@ function AuthenticationMD5Password(type, x, options, pass) {
     .end()
 }
 
-function SASL(type, x, options, pass) {
+function SASL(type, x, options) {
   bytes
     .p()
     .str('SCRAM-SHA-256' + N)

package.json

@@ -6,7 +6,7 @@
   "type": "commonjs",
   "scripts": {
     "test": "node tests/index.js",
-    "lint": "eslint lib",
+    "lint": "eslint lib && eslint tests",
     "prepublishOnly": "npm run lint && npm test"
   },
   "files": [

tests/index.js

@@ -1,4 +1,6 @@
-const { t, not, ot } = require('./test.js')
+/* eslint no-console: 0 */
+
+const { t, not, ot } = require('./test.js') // eslint-disable-line
 const cp = require('child_process')
 const path = require('path')
 
@@ -218,7 +220,7 @@ t('Parallel transactions', async() => {
   await sql`create table test (a int)`
   return ['11', (await Promise.all([
     sql.begin(sql => sql`select 1`),
-    sql.begin(sql => sql`select 1`),
+    sql.begin(sql => sql`select 1`)
   ])).map(x => x.count).join('')]
 }, () => sql`drop table test`)
 
@@ -244,7 +246,7 @@ t('Transaction waits', async() => {
 
   return ['11', (await Promise.all([
     sql.begin(sql => sql`select 1`),
-    sql.begin(sql => sql`select 1`),
+    sql.begin(sql => sql`select 1`)
   ])).map(x => x.count).join('')]
 }, () => sql`drop table test`)
 
@@ -260,7 +262,7 @@ t('Throw syntax error', async() =>
 
 t('Connect using uri', async() =>
   [true, await new Promise((resolve, reject) => {
-    const sql = postgres('postgres://' + login.user + ':' + (login.pass || '') + '@localhost:5432/' + options.db, {
+    const sql = postgres('postgres://' + login.user + ':' + (login.pass || '') + '@localhost:5432/' + options.db, {
       timeout: 0.1
     })
     sql`select 1`.then(() => resolve(true), reject)
@@ -515,7 +517,7 @@ t('double listen', async() => {
   ).then(() => count++)
 
   // for coverage
-  sql.listen('weee', () => {}).then(sql.end)
+  sql.listen('weee', () => { /* noop */ }).then(sql.end)
 
   return [2, count]
 })
@@ -571,7 +573,7 @@ t('await sql() throws not tagged error', async() => {
   let error
   try {
     await sql('select 1')
-  } catch(e) {
+  } catch (e) {
     error = e.code
   }
   return ['NOT_TAGGED_CALL', error]
@@ -580,8 +582,8 @@ t('await sql() throws not tagged error', async() => {
 t('sql().then throws not tagged error', async() => {
   let error
   try {
-    sql('select 1').then(() => {})
-  } catch(e) {
+    sql('select 1').then(() => { /* noop */ })
+  } catch (e) {
     error = e.code
   }
   return ['NOT_TAGGED_CALL', error]
@@ -591,7 +593,7 @@ t('sql().catch throws not tagged error', async() => {
   let error
   try {
     await sql('select 1')
-  } catch(e) {
+  } catch (e) {
     error = e.code
   }
   return ['NOT_TAGGED_CALL', error]
@@ -600,45 +602,45 @@ t('sql().catch throws not tagged error', async() => {
 t('sql().finally throws not tagged error', async() => {
   let error
   try {
-    sql('select 1').finally(() => {})
-  } catch(e) {
+    sql('select 1').finally(() => { /* noop */ })
+  } catch (e) {
     error = e.code
   }
   return ['NOT_TAGGED_CALL', error]
 })
 
-t('dynamic column name', async () => {
+t('dynamic column name', async() => {
   return ['!not_valid', Object.keys((await sql`select 1 as ${ sql('!not_valid') }`)[0])[0]]
 })
 
-t('dynamic select as', async () => {
+t('dynamic select as', async() => {
   return [2, (await sql`select ${ sql({ a: 1, b: 2 }) }`)[0].b]
 })
 
-t('dynamic select as pluck', async () => {
+t('dynamic select as pluck', async() => {
   return [undefined, (await sql`select ${ sql({ a: 1, b: 2 }, 'a') }`)[0].b]
 })
 
-t('dynamic insert', async () => {
+t('dynamic insert', async() => {
   await sql`create table test (a int, b text)`
   const x = { a: 42, b: 'the answer' }
 
   return ['the answer', (await sql`insert into test ${ sql(x) } returning *`)[0].b]
 }, () => sql`drop table test`)
 
-t('dynamic insert pluck', async () => {
+t('dynamic insert pluck', async() => {
   await sql`create table test (a int, b text)`
   const x = { a: 42, b: 'the answer' }
 
   return [null, (await sql`insert into test ${ sql(x, 'a') } returning *`)[0].b]
 }, () => sql`drop table test`)
 
-t('array insert', async () => {
+t('array insert', async() => {
   await sql`create table test (a int, b int)`
-  return [2, (await sql`insert into test (a, b) values (${ [1,2] }) returning *`)[0].b]
+  return [2, (await sql`insert into test (a, b) values (${ [1, 2] }) returning *`)[0].b]
 }, () => sql`drop table test`)
 
-t('parameters in()', async () => {
+t('parameters in()', async() => {
   return [2, (await sql`
     with rows as (
       select * from (values (1), (2), (3), (4)) as x(a)
@@ -647,34 +649,34 @@ t('parameters in()', async () => {
   `).count]
 })
 
-t('dynamic multi row insert', async () => {
+t('dynamic multi row insert', async() => {
   await sql`create table test (a int, b text)`
   const x = { a: 42, b: 'the answer' }
 
   return ['the answer', (await sql`insert into test ${ sql([x, x]) } returning *`)[1].b]
 }, () => sql`drop table test`)
 
-t('dynamic update', async () => {
+t('dynamic update', async() => {
   await sql`create table test (a int, b text)`
   await sql`insert into test (a, b) values (17, 'wrong')`
 
   return ['the answer', (await sql`update test set ${ sql({ a: 42, b: 'the answer' }) } returning *`)[0].b]
 }, () => sql`drop table test`)
 
-t('dynamic update pluck', async () => {
+t('dynamic update pluck', async() => {
   await sql`create table test (a int, b text)`
   await sql`insert into test (a, b) values (17, 'wrong')`
 
   return ['wrong', (await sql`update test set ${ sql({ a: 42, b: 'the answer' }, 'a') } returning *`)[0].b]
 }, () => sql`drop table test`)
 
-t('dynamic select array', async () => {
+t('dynamic select array', async() => {
   await sql`create table test (a int, b text)`
   await sql`insert into test (a, b) values (42, 'yay')`
   return ['yay', (await sql`select ${ sql(['a', 'b']) } from test`)[0].b]
 }, () => sql`drop table test`)
 
-t('dynamic select args', async () => {
+t('dynamic select args', async() => {
   await sql`create table test (a int, b text)`
   await sql`insert into test (a, b) values (42, 'yay')`
   return ['yay', (await sql`select ${ sql('a', 'b') } from test`)[0].b]
@@ -766,13 +768,13 @@ t('Stream works', async() => {
 })
 
 t('Stream returns empty array', async() => {
-  return [0, (await sql`select 1 as x`.stream(x => {})).length]
+  return [0, (await sql`select 1 as x`.stream(() => { /* noop */ })).length]
 })
 
 t('Transform row', async() => {
   const sql = postgres({
     ...options,
-    transform: { row: x => 1 }
+    transform: { row: () => 1 }
   })
 
   return [1, (await sql`select 'wat'`)[0]]
@@ -782,7 +784,7 @@ t('Transform row stream', async() => {
   let result
   const sql = postgres({
     ...options,
-    transform: { row: x => 1 }
+    transform: { row: () => 1 }
   })
 
   await sql`select 1`.stream(x => result = x)
@@ -793,7 +795,7 @@ t('Transform row stream', async() => {
 t('Transform value', async() => {
   const sql = postgres({
     ...options,
-    transform: { value: x => 1 }
+    transform: { value: () => 1 }
   })
 
   return [1, (await sql`select 'wat' as x`)[0].x]
@@ -816,7 +818,7 @@ t('Debug works', async() => {
   let result
   const sql = postgres({
     ...options,
-    debug: (connection_id, str, args) => result = str
+    debug: (connection_id, str) => result = str
   })
 
   await sql`select 1`

tests/test.js

@@ -1,6 +1,7 @@
+/* eslint no-console: 0 */
+
 const util = require('util')
 
-let all = 0
 let done = 0
 let only = false
 let ignored = 0
@@ -56,12 +57,15 @@ function exit() {
       success = false
       x.cleanup
         ? console.error('⛔️', x.name + ' at line', x.line, 'cleanup failed', '\n', util.inspect(x.cleanup))
-        : console.error('⛔️', x.name + ' at line', x.line, x.failed ? 'failed' : 'never finished', '\n', util.inspect(x.error))
+        : console.error('⛔️', x.name + ' at line', x.line, x.failed
+          ? 'failed'
+          : 'never finished', '\n', util.inspect(x.error)
+        )
     }
   })
 
   ignored && console.error('⚠️', ignored, 'ignored test' + (ignored === 1 ? '' : 's', '\n'))
   !only && success && !ignored
     ? console.log('All good')
-    : process.exit(1)
+    : process.exit(1) // eslint-disable-line
 }