Skip to content

Commit 7f0d627

Browse files
authored
Merge pull request #242 from pre-commit/fix_trailing_whitespace_non_utf8_osx
Fix trailing-whitespace on macos for non-utf8 files
2 parents 5d08e77 + 9958d1e commit 7f0d627

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

pre_commit_hooks/trailing_whitespace_fixer.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import os
55
import sys
66

7-
from pre_commit_hooks.util import cmd_output
8-
97

108
def _fix_file(filename, is_markdown):
119
with open(filename, mode='rb') as file_processed:
@@ -50,10 +48,6 @@ def fix_trailing_whitespace(argv=None):
5048
parser.add_argument('filenames', nargs='*', help='Filenames to fix')
5149
args = parser.parse_args(argv)
5250

53-
bad_whitespace_files = cmd_output(
54-
'grep', '-l', '[[:space:]]$', *args.filenames, retcode=None
55-
).strip().splitlines()
56-
5751
md_args = args.markdown_linebreak_ext
5852
if '' in md_args:
5953
parser.error('--markdown-linebreak-ext requires a non-empty argument')
@@ -73,11 +67,11 @@ def fix_trailing_whitespace(argv=None):
7367
)
7468

7569
return_code = 0
76-
for bad_whitespace_file in bad_whitespace_files:
77-
_, extension = os.path.splitext(bad_whitespace_file.lower())
70+
for filename in args.filenames:
71+
_, extension = os.path.splitext(filename.lower())
7872
md = all_markdown or extension in md_exts
79-
if _fix_file(bad_whitespace_file, md):
80-
print('Fixing {}'.format(bad_whitespace_file))
73+
if _fix_file(filename, md):
74+
print('Fixing {}'.format(filename))
8175
return_code = 1
8276
return return_code
8377

0 commit comments

Comments
 (0)