Merge pull request #297 from pre-commit/warnings

Fix resource warnings

Author: asottile

pre_commit_hooks/autopep8_wrapper.py

@@ -14,7 +14,8 @@ def main(argv=None):
 
     retv = 0
     for filename in args.files:
-        original_contents = io.open(filename, encoding='UTF-8').read()
+        with io.open(filename, encoding='UTF-8') as f:
+            original_contents = f.read()
         new_contents = autopep8.fix_code(original_contents, args)
         if original_contents != new_contents:
             print('Fixing {}'.format(filename))

pre_commit_hooks/check_ast.py

@@ -18,7 +18,8 @@ def check_ast(argv=None):
     for filename in args.filenames:
 
         try:
-            ast.parse(open(filename, 'rb').read(), filename=filename)
+            with open(filename, 'rb') as f:
+                ast.parse(f.read(), filename=filename)
         except SyntaxError:
             print('{}: failed parsing with {} {}:'.format(
                 filename,

pre_commit_hooks/check_builtin_literals.py

@@ -47,7 +47,8 @@ def visit_Call(self, node):
 
 
 def check_file_for_builtin_type_constructors(filename, ignore=None, allow_dict_kwargs=True):
-    tree = ast.parse(open(filename, 'rb').read(), filename=filename)
+    with open(filename, 'rb') as f:
+        tree = ast.parse(f.read(), filename=filename)
     visitor = BuiltinTypeVisitor(ignore=ignore, allow_dict_kwargs=allow_dict_kwargs)
     visitor.visit(tree)
     return visitor.builtin_type_calls

pre_commit_hooks/check_docstring_first.py

@@ -58,7 +58,8 @@ def main(argv=None):
     retv = 0
 
     for filename in args.filenames:
-        contents = io.open(filename, encoding='UTF-8').read()
+        with io.open(filename, encoding='UTF-8') as f:
+            contents = f.read()
         retv |= check_docstring_first(contents, filename=filename)
 
     return retv

pre_commit_hooks/debug_statement_hook.py

@@ -36,7 +36,8 @@ def visit_Call(self, node):
 
 def check_file(filename):
     try:
-        ast_obj = ast.parse(open(filename, 'rb').read(), filename=filename)
+        with open(filename, 'rb') as f:
+            ast_obj = ast.parse(f.read(), filename=filename)
     except SyntaxError:
         print('{} - Could not parse ast'.format(filename))
         print()

pre_commit_hooks/string_fixer.py

@@ -32,7 +32,8 @@ def get_line_offsets_by_line_no(src):
 
 
 def fix_strings(filename):
-    contents = io.open(filename, encoding='UTF-8').read()
+    with io.open(filename, encoding='UTF-8') as f:
+        contents = f.read()
     line_offsets = get_line_offsets_by_line_no(contents)
 
     # Basically a mutable string

tests/check_builtin_literals_test.py

@@ -94,7 +94,8 @@ def test_dict_no_allow_kwargs_exprs(expression, calls):
 
 def test_ignore_constructors():
     visitor = BuiltinTypeVisitor(ignore=('complex', 'dict', 'float', 'int', 'list', 'str', 'tuple'))
-    visitor.visit(ast.parse(open(get_resource_path('builtin_constructors.py'), 'rb').read(), 'builtin_constructors.py'))
+    with open(get_resource_path('builtin_constructors.py'), 'rb') as f:
+        visitor.visit(ast.parse(f.read(), 'builtin_constructors.py'))
     assert visitor.builtin_type_calls == []