From f05976b8e8da1ebd68a406003fd5f8ffed4c6dc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carles=20Barrob=C3=A9s?= Date: Sat, 1 Jun 2013 14:38:02 +0100 Subject: [PATCH 1/4] Add bootstrap styles for forms --- deploystream/static/less/bootstrap-modules.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploystream/static/less/bootstrap-modules.less b/deploystream/static/less/bootstrap-modules.less index 798c5e0..8afb5bf 100644 --- a/deploystream/static/less/bootstrap-modules.less +++ b/deploystream/static/less/bootstrap-modules.less @@ -13,7 +13,7 @@ // Base CSS @import "bootstrap/type.less"; @import "bootstrap/code.less"; -// @import "bootstrap/forms.less"; +@import "bootstrap/forms.less"; @import "bootstrap/tables.less"; // Components: common From 5744d5d1ec826f29b58bcfeb9c617d567b2fadc3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carles=20Barrob=C3=A9s?= Date: Sat, 1 Jun 2013 14:38:35 +0100 Subject: [PATCH 2/4] Make create_db script executable --- scripts/create_db.py | 1 + 1 file changed, 1 insertion(+) mode change 100644 => 100755 scripts/create_db.py diff --git a/scripts/create_db.py b/scripts/create_db.py old mode 100644 new mode 100755 index f6d7cca..93e8470 --- a/scripts/create_db.py +++ b/scripts/create_db.py @@ -1,3 +1,4 @@ +#!/usr/bin/env python from deploystream import db db.create_all() From 22fa34bc4e14408f6ca424cdf897889f9bcbd31a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carles=20Barrob=C3=A9s?= Date: Sat, 1 Jun 2013 15:10:41 +0100 Subject: [PATCH 3/4] Improved bootstrap form layout --- deploystream/templates/forms/macros.html | 18 ++++++++++-------- deploystream/templates/users/login.html | 16 +++++++++++----- deploystream/templates/users/register.html | 15 ++++++++++++--- 3 files changed, 33 insertions(+), 16 deletions(-) diff --git a/deploystream/templates/forms/macros.html b/deploystream/templates/forms/macros.html index 5d3f1e0..af8b188 100644 --- a/deploystream/templates/forms/macros.html +++ b/deploystream/templates/forms/macros.html @@ -1,12 +1,14 @@ {% macro render_field(field) %}
- {{ field.label(class="control-label") }} - {% if field.errors %} - {% set css_class = 'has_error ' + kwargs.pop('class', 'input-xlarge') %} - {{ field(class=css_class, **kwargs) }} -
    {% for error in field.errors %}
  • {{ error|e }}
  • {% endfor %}
- {% else %} - {{ field(**kwargs) }} - {% endif %} + {{ field.label(class="control-label") }} +
+ {% if field.errors %} + {% set css_class = 'has_error ' + kwargs.pop('class', 'input-xlarge') %} + {{ field(class=css_class, **kwargs) }} +
    {% for error in field.errors %}
  • {{ error|e }}
  • {% endfor %}
+ {% else %} + {{ field(**kwargs) }} + {% endif %} +
{% endmacro %} diff --git a/deploystream/templates/users/login.html b/deploystream/templates/users/login.html index 21ee7b5..0a3dd6b 100644 --- a/deploystream/templates/users/login.html +++ b/deploystream/templates/users/login.html @@ -1,15 +1,21 @@ {% extends "base.html" %} {% block content %} + {% from "forms/macros.html" import render_field %}
-
- Login -
{{ form.csrf_token }} {{ render_field(form.email, class="input text") }} {{ render_field(form.password, class="input text") }} - +
+ +
- Register {% endblock %} diff --git a/deploystream/templates/users/register.html b/deploystream/templates/users/register.html index 2be4926..c6c6ef8 100644 --- a/deploystream/templates/users/register.html +++ b/deploystream/templates/users/register.html @@ -1,14 +1,23 @@ {% extends "base.html" %} {% block content %} + {% from "forms/macros.html" import render_field %} -
+ {{ form.csrf_token }} {{ render_field(form.name, class="input text") }} {{ render_field(form.email, class="input text") }} {{ render_field(form.password, class="input text") }} {{ render_field(form.confirm, class="input text") }} {{ render_field(form.accept_tos, class="input checkbox") }} - +
+ +
- Login {% endblock %} From f2eb401d0997dab7adb3ddd6196a2b4b0a5fa74a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carles=20Barrob=C3=A9s?= Date: Sun, 2 Jun 2013 00:43:45 +0100 Subject: [PATCH 4/4] Change the approach to login by using a popover --- deploystream/apps/users/views.py | 6 ++++- deploystream/templates/base.html | 25 ++++++++++++++++---- deploystream/templates/navbar.html | 4 +++- deploystream/templates/users/login_ajax.html | 9 +++++++ 4 files changed, 38 insertions(+), 6 deletions(-) create mode 100644 deploystream/templates/users/login_ajax.html diff --git a/deploystream/apps/users/views.py b/deploystream/apps/users/views.py index 5853850..8e8d731 100644 --- a/deploystream/apps/users/views.py +++ b/deploystream/apps/users/views.py @@ -43,7 +43,11 @@ def login(): flash('Welcome %s' % user.name) return redirect(url_for('users.home')) flash('Wrong email or password', 'error-message') - return render_template("users/login.html", form=form) + if request.method == 'POST': + suffix = ".html" + else: + suffix = "_ajax.html" + return render_template("users/login" + suffix, form=form) @mod.route('/register/', methods=['GET', 'POST']) diff --git a/deploystream/templates/base.html b/deploystream/templates/base.html index 24fe0f6..bb39707 100644 --- a/deploystream/templates/base.html +++ b/deploystream/templates/base.html @@ -11,6 +11,11 @@ + + + + + {% block extrahead %} {% endblock %} {% endblock %} @@ -36,10 +41,22 @@ - - - - + {% block scripts %}{% endblock %} diff --git a/deploystream/templates/navbar.html b/deploystream/templates/navbar.html index 5b625b6..f565fde 100644 --- a/deploystream/templates/navbar.html +++ b/deploystream/templates/navbar.html @@ -28,7 +28,9 @@ {% else %} {% endif %} diff --git a/deploystream/templates/users/login_ajax.html b/deploystream/templates/users/login_ajax.html new file mode 100644 index 0000000..b347cf9 --- /dev/null +++ b/deploystream/templates/users/login_ajax.html @@ -0,0 +1,9 @@ +{% from "forms/macros.html" import render_field %} +
+ {{ form.csrf_token }} + {{ render_field(form.email, class="input text", autofocus="autofocus") }} + {{ render_field(form.password, class="input text") }} +
+ +
+