improve error handling and add comprehensive error tests

- Replace console.error with throw Error in all OpenProcessing API functions
- Ensure build fails immediately when API calls fail instead of continuing with invalid data
- Add comprehensive error handling tests for all API functions
- Test various error scenarios: 500 Internal Server Error, 429 Rate Limit, 404 Not Found
- Improve build reliability by failing fast on API issues
- Export priorityIds for better test maintainability

Author: junseok44

src/api/OpenProcessing.ts

@@ -50,16 +50,16 @@ export const getCurationSketches = memoize(async (
   const response1 = await fetch(
     `${openProcessingEndpoint}curation/${curationId}/sketches?${limitParam}`,
   );
-  if(!response1.ok){ //log error instead of throwing error to not cache result in memoize
-    console.error('getCurationSketches', response1.status, response1.statusText)
+  if(!response1.ok){ 
+    throw new Error(`getCurationSketches: ${response1.status} ${response1.statusText}`)
   }
   const payload1 = await response1.json();
 
   const response2 = await fetch(
     `${openProcessingEndpoint}curation/${newCurationId}/sketches?${limitParam}`,
   );
-  if(!response2.ok){ //log error instead of throwing error to not cache result in memoize
-    console.error('getCurationSketches', response2.status, response2.statusText)
+  if(!response2.ok){ 
+    throw new Error(`getCurationSketches: ${response2.status} ${response2.statusText}`)
   }
   const payload2 = await response2.json();
 
@@ -124,8 +124,7 @@ export const getSketch = memoize(
     // check for sketch data in Open Processing API
   const response = await fetch(`${openProcessingEndpoint}sketch/${id}`);
     if (!response.ok) {
-      //log error instead of throwing error to not cache result in memoize
-      console.error("getSketch", id, response.status, response.statusText);
+      throw new Error(`getSketch: ${id} ${response.status} ${response.statusText}`)
   }
   const payload = await response.json();
   return payload as OpenProcessingSketchResponse;
@@ -143,8 +142,8 @@ export const getSketchSize = memoize(async (id: number) => {
   }
 
   const response = await fetch(`${openProcessingEndpoint}sketch/${id}/code`);
-  if(!response.ok){ //log error instead of throwing error to not cache result in memoize
-    console.error('getSketchSize', id, response.status, response.statusText)
+  if(!response.ok){ 
+    throw new Error(`getSketchSize: ${id} ${response.status} ${response.statusText}`)
   }
   const payload = await response.json();
 

test/api/OpenProcessing.test.ts

@@ -145,4 +145,87 @@ describe('OpenProcessing API Caching', () => {
     expect(mockFetch).toHaveBeenCalledTimes(expectedCalls);
 
   });
-});
+});
+
+describe('Error Handling', () => {
+
+    beforeEach(() => {
+        vi.clearAllMocks();
+    
+        getCurationSketches.cache.clear?.();
+        getSketch.cache.clear?.();
+        getSketchSize.cache.clear?.();
+      });
+      
+    it('should throw an error when getCurationSketches API call fails', async () => {
+      mockFetch.mockResolvedValue({
+        ok: false,
+        status: 500,
+        statusText: 'Internal Server Error',
+      });
+  
+      await expect(getCurationSketches()).rejects.toThrow(
+        'getCurationSketches: 500 Internal Server Error'
+      );
+    });
+  
+    it('should throw an error when rate limit is exceeded (429)', async () => {
+      mockFetch.mockResolvedValue({
+        ok: false,
+        status: 429,
+        statusText: 'Too Many Requests',
+      });
+  
+      await expect(getCurationSketches()).rejects.toThrow(
+        'getCurationSketches: 429 Too Many Requests'
+      );
+    });
+  
+    it('should throw an error when getSketch API call fails for individual sketch', async () => {
+      // Setup empty curations first
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: () => Promise.resolve([])
+      }).mockResolvedValueOnce({
+        ok: true,
+        json: () => Promise.resolve([])
+      });
+  
+      await getCurationSketches(); // Create empty cache
+  
+      // Individual sketch API call fails with 429
+      mockFetch.mockResolvedValueOnce({
+        ok: false,
+        status: 429,
+        statusText: 'Too Many Requests'
+      });
+  
+      await expect(getSketch(999)).rejects.toThrow(
+        'getSketch: 999 429 Too Many Requests'
+      );
+    });
+  
+    it('should throw an error when getSketchSize API call fails', async () => {
+      // Setup sketch data first
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: () => Promise.resolve([getCurationSketchesData[0]])
+      }).mockResolvedValueOnce({
+        ok: true,
+        json: () => Promise.resolve([])
+      });
+  
+      await getCurationSketches();
+  
+      // getSketchSize API call fails with rate limit
+      mockFetch.mockResolvedValueOnce({
+        ok: false,
+        status: 429,
+        statusText: 'Too Many Requests'
+      });
+  
+      await expect(getSketchSize(getCurationSketchesData[0].visualID)).rejects.toThrow(
+        `getSketchSize: ${getCurationSketchesData[0].visualID} 429 Too Many Requests`
+      );
+    });
+  });