chore: created trait to get Language and UnitSystem options list without value repetition

Author: andrepimpao

src/Language/Language.php

@@ -2,8 +2,12 @@
 
 namespace ProgrammatorDev\OpenWeatherMap\Language;
 
+use ProgrammatorDev\OpenWeatherMap\Util\ClassConstantsTrait;
+
 class Language
 {
+    use ClassConstantsTrait;
+
     public const AFRIKAANS = 'af';
     public const ALBANIAN = 'al';
     public const ARABIC = 'ar';
@@ -53,53 +57,6 @@ class Language
 
     public static function getList(): array
     {
-        return [
-            self::AFRIKAANS,
-            self::ALBANIAN,
-            self::ARABIC,
-            self::AZERBAIJANI,
-            self::BULGARIAN,
-            self::CATALAN,
-            self::CZECH,
-            self::DANISH,
-            self::GERMAN,
-            self::GREEK,
-            self::ENGLISH,
-            self::SPANISH,
-            self::BASQUE,
-            self::PERSIAN_FARSI,
-            self::FINNISH,
-            self::FRENCH,
-            self::GALICIAN,
-            self::HEBREW,
-            self::HINDI,
-            self::CROATIAN,
-            self::HUNGARIAN,
-            self::INDONESIAN,
-            self::ITALIAN,
-            self::JAPANESE,
-            self::KOREAN,
-            self::LATVIAN,
-            self::LITHUANIAN,
-            self::MACEDONIAN,
-            self::NORWEGIAN,
-            self::DUTCH,
-            self::POLISH,
-            self::PORTUGUESE,
-            self::PORTUGUESE_BRAZIL,
-            self::ROMANIAN,
-            self::RUSSIAN,
-            self::SWEDISH,
-            self::SLOVAK,
-            self::SLOVENIAN,
-            self::SERBIAN,
-            self::THAI,
-            self::TURKISH,
-            self::UKRAINIAN,
-            self::VIETNAMESE,
-            self::CHINESE_SIMPLIFIED,
-            self::CHINESE_TRADITIONAL,
-            self::ZULU
-        ];
+        return (new Language)->getClassConstants(self::class);
     }
 }

src/UnitSystem/UnitSystem.php

@@ -2,18 +2,18 @@
 
 namespace ProgrammatorDev\OpenWeatherMap\UnitSystem;
 
+use ProgrammatorDev\OpenWeatherMap\Util\ClassConstantsTrait;
+
 class UnitSystem
 {
+    use ClassConstantsTrait;
+
     public const METRIC = 'metric';
     public const IMPERIAL = 'imperial';
     public const STANDARD = 'standard';
 
     public static function getList(): array
     {
-        return [
-            self::METRIC,
-            self::IMPERIAL,
-            self::STANDARD
-        ];
+        return (new UnitSystem)->getClassConstants(self::class);
     }
 }

src/Util/ClassConstantsTrait.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace ProgrammatorDev\OpenWeatherMap\Util;
+
+trait ClassConstantsTrait
+{
+    private function getClassConstants(string $className): array
+    {
+        $reflection = new \ReflectionClass($className);
+        $constants = $reflection->getConstants();
+
+        // Sort by alphabetical order
+        // to be more intuitive when listing values for error messages
+        \asort($constants);
+
+        return $constants;
+    }
+}