From fe5c7297fffd2a36d44911e54b572cdccfe74334 Mon Sep 17 00:00:00 2001 From: David Grove Date: Fri, 11 Apr 2025 09:50:59 -0400 Subject: [PATCH] appwrapper controller needs rbacs to manipulate events --- config/rbac/role.yaml | 9 +++++++++ internal/controller/appwrapper/appwrapper_controller.go | 3 +++ 2 files changed, 12 insertions(+) diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml index 591868c..4698578 100644 --- a/config/rbac/role.yaml +++ b/config/rbac/role.yaml @@ -4,6 +4,15 @@ kind: ClusterRole metadata: name: manager-role rules: +- apiGroups: + - "" + resources: + - events + verbs: + - create + - patch + - update + - watch - apiGroups: - "" resources: diff --git a/internal/controller/appwrapper/appwrapper_controller.go b/internal/controller/appwrapper/appwrapper_controller.go index 0f4b66c..10f1385 100644 --- a/internal/controller/appwrapper/appwrapper_controller.go +++ b/internal/controller/appwrapper/appwrapper_controller.go @@ -79,6 +79,9 @@ type componentStatusSummary struct { //+kubebuilder:rbac:groups=workload.codeflare.dev,resources=appwrappers/status,verbs=get;update;patch //+kubebuilder:rbac:groups=workload.codeflare.dev,resources=appwrappers/finalizers,verbs=update +// permission for events +//+kubebuilder:rbac:groups="",resources=events,verbs=create;watch;update;patch + // permission to edit wrapped resources: pods, services, jobs, podgroups, pytorchjobs, rayclusters, jobsets //+kubebuilder:rbac:groups="",resources=pods;services,verbs=get;list;watch;create;update;patch;delete