From 592e4bb893ee2e80bfd0da7492578f606e04c6c8 Mon Sep 17 00:00:00 2001 From: David Grove Date: Thu, 14 Nov 2024 18:56:04 -0500 Subject: [PATCH] Ignore finished workloads when scanning for abnormal conditions --- tools/cluster-checker/checker.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/cluster-checker/checker.js b/tools/cluster-checker/checker.js index 3e49990..671c6a7 100644 --- a/tools/cluster-checker/checker.js +++ b/tools/cluster-checker/checker.js @@ -222,11 +222,13 @@ async function checkUserNamespace (client, namespace, queues) { for (const condition of workload.status?.conditions ?? []) { conditions[condition.type] = condition.status } - if (conditions.Admitted === 'True' && conditions.PodsReady === 'False') { - console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has conditions Admitted=True and PodsReady=False`) - } - if (conditions.Evicted === 'True') { - console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has condition Evicted=True`) + if (conditions.Finished !== 'True') { + if (conditions.Admitted === 'True' && conditions.PodsReady === 'False') { + console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has conditions Admitted=True and PodsReady=False`) + } + if (conditions.Evicted === 'True') { + console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has condition Evicted=True`) + } } // report misconfigured resource requests