Skip to content
This repository was archived by the owner on Dec 1, 2020. It is now read-only.

Commit 8bb99fa

Browse files
authored
Merge pull request #162 from project-march/fix/ethercat-grant
Use ethercat_grant instead of custom sudo target
2 parents 0c47326 + b307b3e commit 8bb99fa

File tree

7 files changed

+5
-21
lines changed

7 files changed

+5
-21
lines changed

march_hardware/CMakeLists.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,6 @@ install(TARGETS slave_count_check
8989
RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
9090
)
9191

92-
# Give sudo access to ethernet port
93-
add_custom_command(
94-
TARGET slave_count_check
95-
COMMAND sudo setcap cap_net_raw+ep slave_count_check
96-
WORKING_DIRECTORY ${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_BIN_DESTINATION}
97-
POST_BUILD
98-
)
99-
10092
## Add gtest based cpp test target and link libraries
10193
if (CATKIN_ENABLE_TESTING)
10294

march_hardware_interface/CMakeLists.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ install(DIRECTORY config launch
5757
DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}
5858
)
5959

60-
# Give sudo access to ethernet port
61-
add_custom_command(
62-
TARGET ${PROJECT_NAME}_node
63-
COMMAND sudo setcap cap_net_raw+ep ${PROJECT_NAME}_node
64-
WORKING_DIRECTORY ${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_BIN_DESTINATION}
65-
POST_BUILD
66-
)
67-
6860
## Add gtest based cpp test target and link libraries
6961
if (CATKIN_ENABLE_TESTING)
7062

march_hardware_interface/launch/march3_hardware.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
/march/controller/trajectory
1515
"/>
1616

17-
<node name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="march3" output="screen"/>
17+
<node launch-prefix="ethercat_grant" name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="march3" output="screen"/>
1818

1919
</launch>

march_hardware_interface/launch/march4.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
/march/controller/trajectory
1414
"/>
1515

16-
<node name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="march4" output="screen"/>
16+
<node launch-prefix="ethercat_grant" name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="march4" output="screen"/>
1717

1818
</launch>

march_hardware_interface/launch/pdb.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
/march/controller/pdb_state
77
"/>
88

9-
<node name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="pdb" output="screen"/>
9+
<node launch-prefix="ethercat_grant" name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="pdb" output="screen"/>
1010

1111
</launch>

march_hardware_interface/launch/testjoint_linear.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@
2222
/march/controller/trajectory
2323
"/>
2424

25-
<node name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="testjoint_linear" output="screen"/>
25+
<node launch-prefix="ethercat_grant" name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="testjoint_linear" output="screen"/>
2626

2727
</launch>

march_hardware_interface/launch/testjoint_rotational.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
/march/controller/trajectory
1313
"/>
1414

15-
<node name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="testjoint_rotational" output="screen"/>
15+
<node launch-prefix="ethercat_grant" name="march_hardware_interface" pkg="march_hardware_interface" type="march_hardware_interface_node" args="testjoint_rotational" output="screen"/>
1616

1717
</launch>

0 commit comments

Comments
 (0)