Add tests to cover the full vs mock cldr coverage

Author: zbraniecki

src/negotiate/likely_subtags.rs

@@ -5,35 +5,35 @@ static REGION_MATCHING_KEYS: &[&str] = &[
 ];
 
 pub trait MockLikelySubtags {
-  fn add_likely_subtags(&mut self) -> bool;
+    fn add_likely_subtags(&mut self) -> bool;
 }
 
 impl MockLikelySubtags for LanguageIdentifier {
-  fn add_likely_subtags(&mut self) -> bool {
-      let extended = match self.to_string().as_str() {
-        "en" => "en-Latn-US",
-        "fr" => "fr-Latn-FR",
-        "sr" => "sr-Cyrl-SR",
-        "sr-RU" => "sr-Latn-SR",
-        "az-IR" => "az-Arab-IR",
-        "zh-GB" => "zh-Hant-GB",
-        "zh-US" => "zh-Hant-US",
-        _ => {
-            let lang = self.get_language();
+    fn add_likely_subtags(&mut self) -> bool {
+        let extended = match self.to_string().as_str() {
+            "en" => "en-Latn-US",
+            "fr" => "fr-Latn-FR",
+            "sr" => "sr-Cyrl-SR",
+            "sr-RU" => "sr-Latn-SR",
+            "az-IR" => "az-Arab-IR",
+            "zh-GB" => "zh-Hant-GB",
+            "zh-US" => "zh-Hant-US",
+            _ => {
+                let lang = self.get_language();
 
-            for subtag in REGION_MATCHING_KEYS {
-              if lang == *subtag {
-                  self.set_region(Some(subtag)).unwrap();
-                  return true;
-              }
+                for subtag in REGION_MATCHING_KEYS {
+                    if lang == *subtag {
+                        self.set_region(Some(subtag)).unwrap();
+                        return true;
+                    }
+                }
+                return false;
             }
-            return false;
-        }
-      };
-      let langid: LanguageIdentifier = extended.parse().expect("Failed to parse langid.");
-      self.set_language(Some(langid.get_language())).unwrap();
-      self.set_script(langid.get_script()).unwrap();
-      self.set_region(langid.get_region()).unwrap();
-      return true;
-  }
+        };
+        let langid: LanguageIdentifier = extended.parse().expect("Failed to parse langid.");
+        self.set_language(Some(langid.get_language())).unwrap();
+        self.set_script(langid.get_script()).unwrap();
+        self.set_region(langid.get_region()).unwrap();
+        return true;
+    }
 }

tests/lib.rs

@@ -154,6 +154,34 @@ fn langid_matching() {
     );
 }
 
+#[test]
+fn cldr_feature() {
+    // In this case, the full likelySubtags algorithm knows that `mn` -> `mn-Cyrl`, but
+    // the mock doesn't.
+    #[cfg(feature = "cldr")]
+    assert_eq!(
+        negotiate_languages(
+            &[langid!("mn")],
+            &[langid!("mn-Latn"), langid!("mn-Cyrl")],
+            None,
+            NegotiationStrategy::Filtering
+        ),
+        &[&langid!("mn-Cyrl")]
+    );
+
+    // In result, the mock will just return them in order.
+    #[cfg(not(feature = "cldr"))]
+    assert_eq!(
+        negotiate_languages(
+            &[langid!("mn")],
+            &[langid!("mn-Latn"), langid!("mn-Cyrl")],
+            None,
+            NegotiationStrategy::Filtering
+        ),
+        &[&langid!("mn-Latn"), &langid!("mn-Cyrl")]
+    );
+}
+
 #[test]
 fn locale_matching() {
     let loc_en_us = locale!("en-US-u-hc-h12");