Skip to content

Commit 93d342a

Browse files
committed
Some missing/badly written tests.
Thanks @stasm
1 parent bf59c8d commit 93d342a

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

fluent.runtime/tests/format/test_attributes.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,11 @@ def test_works_with_self_references(self):
8484
self.assertEqual(val, 'Qux Attribute')
8585
self.assertEqual(len(errs), 0)
8686

87+
def test_works_with_self_references_direct(self):
88+
val, errs = self.ctx.format('qux.attr', {})
89+
self.assertEqual(val, 'Qux Attribute')
90+
self.assertEqual(len(errs), 0)
91+
8792

8893
class TestMissing(unittest.TestCase):
8994
def setUp(self):

fluent.runtime/tests/format/test_primitives.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@ def setUp(self):
1515
placeable-literal = { "Foo" } Bar
1616
placeable-message = { foo } Bar
1717
selector-literal = { "Foo" ->
18-
*[Foo] Member 1
18+
[Foo] Member 1
19+
*[Bar] Member 2
1920
}
2021
bar
2122
.attr = Bar Attribute
2223
placeable-attr = { bar.attr }
2324
-baz = Baz
2425
.attr = BazAttribute
2526
selector-attr = { -baz.attr ->
26-
*[BazAttribute] Member 3
27+
[BazAttribute] Member 3
28+
*[other] Member 4
2729
}
2830
"""))
2931

fluent.runtime/tests/format/test_select_expression.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,16 @@ def test_with_a_missing_selector(self):
160160
self.assertEqual(errs,
161161
[FluentReferenceError("Unknown external: num")])
162162

163-
def test_with_argument(self):
163+
def test_with_argument_integer(self):
164164
val, errs = self.ctx.format('qux', {'num': 1})
165165
self.assertEqual(val, "A")
166166
self.assertEqual(len(errs), 0)
167167

168168
val, errs = self.ctx.format('qux', {'num': 2})
169169
self.assertEqual(val, "B")
170170
self.assertEqual(len(errs), 0)
171+
172+
def test_with_argument_float(self):
173+
val, errs = self.ctx.format('qux', {'num': 1.0})
174+
self.assertEqual(val, "A")
175+
self.assertEqual(len(errs), 0)

0 commit comments

Comments
 (0)