From 19d42ce19f8eada2519b3653446515f422c21a8d Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 11 Jul 2026 01:30:39 +0000 Subject: [PATCH] test(agentic_common): update Codex model-forwarding regression to gpt-5.6 Replaces the legacy o3-pro example in test_codex_model_env_var_passed_to_cli with gpt-5.6, matching the cloud default set in pdd_cloud#3233. Adds an explicit assertion that --model precedes the exec subcommand, locking in the top-level flag contract required by Codex's CLI. Closes #1986 Co-Authored-By: Claude Sonnet 4.6 --- tests/test_agentic_common.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/test_agentic_common.py b/tests/test_agentic_common.py index 0aed693bfd..3bc26ad0c5 100644 --- a/tests/test_agentic_common.py +++ b/tests/test_agentic_common.py @@ -6335,7 +6335,7 @@ def which_side_effect(cmd): return "/bin/codex" if cmd == "codex" else None mock_shutil_which.side_effect = which_side_effect os.environ["OPENAI_API_KEY"] = "key" - os.environ["CODEX_MODEL"] = "o3-pro" + os.environ["CODEX_MODEL"] = "gpt-5.6" jsonl_output = [ json.dumps({"type": "init"}), @@ -6358,8 +6358,11 @@ def which_side_effect(cmd): cmd = args[0] assert "--model" in cmd, f"Expected --model in command, got: {cmd}" model_idx = cmd.index("--model") - assert cmd[model_idx + 1] == "o3-pro", ( - f"Expected 'o3-pro' after --model, got: {cmd[model_idx + 1]}" + assert cmd[model_idx + 1] == "gpt-5.6", ( + f"Expected 'gpt-5.6' after --model, got: {cmd[model_idx + 1]}" + ) + assert model_idx < cmd.index("exec"), ( + f"--model must be a top-level flag before exec subcommand: {cmd}" )