You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @protobi-pieter — opening this as a single tracking issue so triaging the open senoff PRs is one click instead of nine. Context: I maintain xlsx-for-ai (npm, ~100+ downloads/day), which depends on @protobi/exceljs. The 9 PRs below are upstream contributions back to your fork — fixes I needed downstream that seemed worth contributing here rather than carrying patches. No urgency; this issue is just to consolidate the notification surface. If any of these aren't a fit (different design preference, scope mismatch), close + I'll carry the patch downstream — no offense taken either way.
Priority order (highest → lowest impact for typical users)
Dependency hygiene (gift PR — consider after the above)
chore(deps): bump uuid 8.3.0 → 14.0.0 to clear audit notice #60 — chore(deps): bump uuid 8.3.0 → 14.0.0 to clear audit notice — clears the only npm audit notice downstream consumers inherit. Note: I'd suggest 9.x rather than 14.x if you'd prefer a smaller jump; happy to amend.
Notes for triage
Each PR has tests covering the regression it fixes.
All branch off master cleanly as of opening; will rebase if any conflict after partial merges.
Happy to squash any subset into a single PR if that reduces review overhead — say the word.
Happy to split any PR further if the diff is too coarse — same.
If you want me to add a CHANGELOG / release-note entry per PR, point me at the convention you prefer.
Thanks for keeping the fork alive — the pivot/chart preservation work in protobi.9 is exactly why downstream consumers (myself included) chose @protobi/exceljs over the upstream package.
Hi @protobi-pieter — opening this as a single tracking issue so triaging the open senoff PRs is one click instead of nine. Context: I maintain
xlsx-for-ai(npm, ~100+ downloads/day), which depends on@protobi/exceljs. The 9 PRs below are upstream contributions back to your fork — fixes I needed downstream that seemed worth contributing here rather than carrying patches. No urgency; this issue is just to consolidate the notification surface. If any of these aren't a fit (different design preference, scope mismatch), close + I'll carry the patch downstream — no offense taken either way.Priority order (highest → lowest impact for typical users)
Bug fixes
xdr:wsDrdrawing root (DrawingXform parser hangs on workbook drawings with non-xdr:wsDr root element #56) — parser hang on certain valid OOXML; reproducible.Invalid Dateobject returned for formula result formatted as date exceljs/exceljs#2966: convert formula result to Date when numFmt is date-like — long-standing upstream issue; round-trip data type was wrong.FormulaValueexceljs/exceljs#2943: preserve falsy formula results (0, false, empty string) in copy — subtle data loss on copy ops.getWorksheetcase-insensitive to matchaddWorksheet— API consistency.Lint / dev-experience
Dependency hygiene (gift PR — consider after the above)
npm auditnotice downstream consumers inherit. Note: I'd suggest 9.x rather than 14.x if you'd prefer a smaller jump; happy to amend.Notes for triage
mastercleanly as of opening; will rebase if any conflict after partial merges.Thanks for keeping the fork alive — the pivot/chart preservation work in protobi.9 is exactly why downstream consumers (myself included) chose
@protobi/exceljsover the upstream package.— @senoff