From a88b340f1f046dc8abc8f4aa76081959fd50afd1 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 13:46:46 +0200 Subject: [PATCH 1/8] updating github workflow setup --- .github/workflows/R-CMD-check.yml | 46 +++++++++++++++++-------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index 0239214..926536e 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -18,43 +18,49 @@ jobs: build: runs-on: ${{ matrix.config.os }} - name: ${{ matrix.config.os }} (${{ matrix.config.r-version }}) + name: ${{ matrix.config.os }} (${{ matrix.config.r }}) strategy: fail-fast: false matrix: config: - - {os: macos-latest, r-version: 'release'} - - {os: windows-latest, r-version: 'release'} - - {os: ubuntu-18.04, r-version: 'devel'} - - {os: ubuntu-18.04, r-version: 'release'} - - {os: ubuntu-18.04, r-version: 'oldrel'} + - {os: macos-latest, r: 'release'} + - {os: windows-latest, r: 'release'} + - {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'} + - {os: ubuntu-latest, r: 'release'} + - {os: ubuntu-latest, r: 'oldrel-1'} steps: - - uses: actions/checkout@v2 - - name: Set up R ${{ matrix.r-version }} - uses: r-lib/actions/setup-r@v1 + - uses: actions/checkout@v4 + + - name: Set up R ${{ matrix.config.r }} + uses: r-lib/actions/setup-r@v2 with: - r-version: ${{ matrix.r-version }} - - uses: r-lib/actions/setup-pandoc@v1 + r-version: ${{ matrix.config.r }} + http-user-agent: ${{ matrix.config.http-user-agent }} + + - uses: r-lib/actions/setup-pandoc@v2 - name: Install system dependencies if: runner.os == 'Linux' - env: - RHUB_PLATFORM: linux-x86_64-ubuntu-gcc - run: sudo apt-get install -y libcurl4-openssl-dev + run: | + sudo apt-get update + sudo apt-get install -y libcurl4-openssl-dev - - uses: r-lib/actions/setup-r-dependencies@v1 + - uses: r-lib/actions/setup-r-dependencies@v2 with: - extra-packages: rcmdcheck + extra-packages: any::rcmdcheck + needs: check - name: Check - run: rcmdcheck::rcmdcheck(args = "--no-manual", error_on = "warning", check_dir = "check") - shell: Rscript {0} + uses: r-lib/actions/check-r-package@v2 + with: + error-on: warning + check-dir: check - name: Upload check results if: failure() - uses: actions/upload-artifact@master + uses: actions/upload-artifact@v3 with: - name: ${{ runner.os }}-r${{ matrix.config.r-version }}-results + name: ${{ runner.os }}-r${{ matrix.config.r }}-results path: check From 8fc74d290d078340578923bcdcc77ff7c8196c10 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 13:48:34 +0200 Subject: [PATCH 2/8] updating version of upload-artifact --- .github/workflows/R-CMD-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index 926536e..3d06c88 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -60,7 +60,7 @@ jobs: - name: Upload check results if: failure() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ runner.os }}-r${{ matrix.config.r }}-results path: check From 18fbf5e798331dd6283ad90b5b04c979df3ce809 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 13:53:49 +0200 Subject: [PATCH 3/8] one more attempt --- .github/workflows/R-CMD-check.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index 3d06c88..d4d9528 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -50,13 +50,11 @@ jobs: - uses: r-lib/actions/setup-r-dependencies@v2 with: extra-packages: any::rcmdcheck - needs: check - - name: Check - uses: r-lib/actions/check-r-package@v2 + - uses: r-lib/actions/check-r-package@v2 with: error-on: warning - check-dir: check + upload-snapshots: true - name: Upload check results if: failure() From 749c2098284fc574091cfc64d10134525039b515 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 13:59:44 +0200 Subject: [PATCH 4/8] one more check --- .github/workflows/R-CMD-check.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index d4d9528..bceb2fb 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -51,11 +51,16 @@ jobs: with: extra-packages: any::rcmdcheck - - uses: r-lib/actions/check-r-package@v2 + - name: Check + uses: r-lib/actions/check-r-package@v2 with: - error-on: warning - upload-snapshots: true - + args: --no-manual + error-on: "warning" + + - name: Show testthat output + if: always() + run: find check -name 'testthat.Rout*' -exec cat '{}' \; || true + - name: Upload check results if: failure() uses: actions/upload-artifact@v4 From 0ba7b2fab95bb9506f3e2e884b79c907d8392b68 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 14:07:33 +0200 Subject: [PATCH 5/8] simplifying check --- .github/workflows/R-CMD-check.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index bceb2fb..9bd2d1c 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -52,10 +52,15 @@ jobs: extra-packages: any::rcmdcheck - name: Check - uses: r-lib/actions/check-r-package@v2 - with: - args: --no-manual - error-on: "warning" + env: + _R_CHECK_CRAN_INCOMING_: false + _R_CHECK_FORCE_SUGGESTS_: false + _R_CHECK_SYSTEM_CLOCK_: false + NOT_CRAN: true + run: | + options(crayon.enabled = TRUE) + rcmdcheck::rcmdcheck(args = c("--no-manual"), error_on = "warning", check_dir = "check") + shell: Rscript {0} - name: Show testthat output if: always() From a9c79fa2b4d5139539dc4759ad964fdc98b0fb91 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 14:20:36 +0200 Subject: [PATCH 6/8] trying to solve windows issues --- .github/workflows/R-CMD-check.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index 9bd2d1c..d4b8beb 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -62,9 +62,15 @@ jobs: rcmdcheck::rcmdcheck(args = c("--no-manual"), error_on = "warning", check_dir = "check") shell: Rscript {0} - - name: Show testthat output - if: always() - run: find check -name 'testthat.Rout*' -exec cat '{}' \; || true + - name: Show testthat output (Unix-like) + if: always() && runner.os != 'Windows' + run: find check -name 'testthat.Rout*' -exec cat '{}' \; + + - name: Show testthat output (Windows) + if: always() && runner.os == 'Windows' + run: | + Get-ChildItem -Path "check" -Recurse -Filter "testthat.Rout*" | ForEach-Object { Get-Content $_.FullName } + shell: pwsh - name: Upload check results if: failure() From 61dcb8f74bd2c4c6d20902e26ec65fc743c84ea2 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 14:21:52 +0200 Subject: [PATCH 7/8] simplifying --- .github/workflows/R-CMD-check.yml | 48 ++++++++++++------------------- 1 file changed, 19 insertions(+), 29 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index d4b8beb..9dd79d6 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -2,9 +2,6 @@ # They are provided by a third-party and are governed by # separate terms of service, privacy policy, and support # documentation. -# -# See https://github.com/r-lib/actions/tree/master/examples#readme for -# additional example workflows available for the R community. name: R-CMD-check @@ -15,7 +12,7 @@ on: branches: [ master ] jobs: - build: + R-CMD-check: runs-on: ${{ matrix.config.os }} name: ${{ matrix.config.os }} (${{ matrix.config.r }}) @@ -32,49 +29,42 @@ jobs: steps: - uses: actions/checkout@v4 - + - name: Set up R ${{ matrix.config.r }} uses: r-lib/actions/setup-r@v2 with: r-version: ${{ matrix.config.r }} http-user-agent: ${{ matrix.config.http-user-agent }} - - - uses: r-lib/actions/setup-pandoc@v2 - - - name: Install system dependencies + use-public-rspm: true + + - name: Set up pandoc + uses: r-lib/actions/setup-pandoc@v2 + + - name: Install system dependencies on Linux if: runner.os == 'Linux' run: | sudo apt-get update - sudo apt-get install -y libcurl4-openssl-dev - - - uses: r-lib/actions/setup-r-dependencies@v2 + sudo apt-get install -y libcurl4-openssl-dev libharfbuzz-dev libfribidi-dev + + - name: Install dependencies + uses: r-lib/actions/setup-r-dependencies@v2 with: extra-packages: any::rcmdcheck - + needs: check + - name: Check env: _R_CHECK_CRAN_INCOMING_: false _R_CHECK_FORCE_SUGGESTS_: false - _R_CHECK_SYSTEM_CLOCK_: false - NOT_CRAN: true run: | - options(crayon.enabled = TRUE) - rcmdcheck::rcmdcheck(args = c("--no-manual"), error_on = "warning", check_dir = "check") + rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), + error_on = "warning", + check_dir = "check") shell: Rscript {0} - - - name: Show testthat output (Unix-like) - if: always() && runner.os != 'Windows' - run: find check -name 'testthat.Rout*' -exec cat '{}' \; - - - name: Show testthat output (Windows) - if: always() && runner.os == 'Windows' - run: | - Get-ChildItem -Path "check" -Recurse -Filter "testthat.Rout*" | ForEach-Object { Get-Content $_.FullName } - shell: pwsh - + - name: Upload check results if: failure() uses: actions/upload-artifact@v4 with: - name: ${{ runner.os }}-r${{ matrix.config.r }}-results + name: ${{ matrix.config.os }}-r${{ matrix.config.r }}-results path: check From ae1edeb91444155f1aaa9ae01cc7427d48aa1194 Mon Sep 17 00:00:00 2001 From: Piotr Sobczyk Date: Thu, 19 Jun 2025 14:28:28 +0200 Subject: [PATCH 8/8] rolling back to previous commit --- .github/workflows/R-CMD-check.yml | 48 +++++++++++++++++++------------ 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index 9dd79d6..d4b8beb 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -2,6 +2,9 @@ # They are provided by a third-party and are governed by # separate terms of service, privacy policy, and support # documentation. +# +# See https://github.com/r-lib/actions/tree/master/examples#readme for +# additional example workflows available for the R community. name: R-CMD-check @@ -12,7 +15,7 @@ on: branches: [ master ] jobs: - R-CMD-check: + build: runs-on: ${{ matrix.config.os }} name: ${{ matrix.config.os }} (${{ matrix.config.r }}) @@ -29,42 +32,49 @@ jobs: steps: - uses: actions/checkout@v4 - + - name: Set up R ${{ matrix.config.r }} uses: r-lib/actions/setup-r@v2 with: r-version: ${{ matrix.config.r }} http-user-agent: ${{ matrix.config.http-user-agent }} - use-public-rspm: true - - - name: Set up pandoc - uses: r-lib/actions/setup-pandoc@v2 - - - name: Install system dependencies on Linux + + - uses: r-lib/actions/setup-pandoc@v2 + + - name: Install system dependencies if: runner.os == 'Linux' run: | sudo apt-get update - sudo apt-get install -y libcurl4-openssl-dev libharfbuzz-dev libfribidi-dev - - - name: Install dependencies - uses: r-lib/actions/setup-r-dependencies@v2 + sudo apt-get install -y libcurl4-openssl-dev + + - uses: r-lib/actions/setup-r-dependencies@v2 with: extra-packages: any::rcmdcheck - needs: check - + - name: Check env: _R_CHECK_CRAN_INCOMING_: false _R_CHECK_FORCE_SUGGESTS_: false + _R_CHECK_SYSTEM_CLOCK_: false + NOT_CRAN: true run: | - rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), - error_on = "warning", - check_dir = "check") + options(crayon.enabled = TRUE) + rcmdcheck::rcmdcheck(args = c("--no-manual"), error_on = "warning", check_dir = "check") shell: Rscript {0} - + + - name: Show testthat output (Unix-like) + if: always() && runner.os != 'Windows' + run: find check -name 'testthat.Rout*' -exec cat '{}' \; + + - name: Show testthat output (Windows) + if: always() && runner.os == 'Windows' + run: | + Get-ChildItem -Path "check" -Recurse -Filter "testthat.Rout*" | ForEach-Object { Get-Content $_.FullName } + shell: pwsh + - name: Upload check results if: failure() uses: actions/upload-artifact@v4 with: - name: ${{ matrix.config.os }}-r${{ matrix.config.r }}-results + name: ${{ runner.os }}-r${{ matrix.config.r }}-results path: check