Merge pull request FRRouting#20082 from krishna-samy/krishnasamyr/coverity

lib: Coverity fixes

Author: ton31337

lib/if.c

@@ -1075,6 +1075,8 @@ void if_terminate(struct vrf *vrf)
 
 	while (!RB_EMPTY(if_name_head, &vrf->ifaces_by_name)) {
 		ifp = RB_ROOT(if_name_head, &vrf->ifaces_by_name);
+		if (!ifp)
+			break;
 		if_delete(&ifp);
 	}
 }
@@ -1589,6 +1591,12 @@ static int lib_interface_create(struct nb_cb_create_args *args)
 					     VRF_DEFAULT_NAME);
 		}
 
+		if (!ifp) {
+			snprintf(args->errmsg, args->errmsg_len, "failed to create interface '%s'",
+				 ifname);
+			return NB_ERR_RESOURCE;
+		}
+
 		ifp->configured = true;
 		nb_running_set_entry(args->dnode, ifp);
 		break;

lib/nexthop_group.c

@@ -1115,7 +1115,8 @@ void nexthop_group_json_nexthop(json_object *j, const struct nexthop *nh)
 
 	if (nh->vrf_id != VRF_DEFAULT) {
 		vrf = vrf_lookup_by_id(nh->vrf_id);
-		json_object_string_add(j, "targetVrf", vrf->name);
+		/* When VRF is not initialized or unknown, show the target VRF as none */
+		json_object_string_add(j, "targetVrf", vrf ? vrf->name : "-");
 	}
 
 	if (nh->nh_label && nh->nh_label->num_labels > 0) {

lib/vrf.c

@@ -487,6 +487,8 @@ void vrf_bitmap_set(vrf_bitmap_t *pbmap, vrf_id_t vrf_id)
 		vrf_hash = *pbmap;
 
 	bit = hash_get(vrf_hash, &lookup, vrf_hash_bitmap_alloc);
+	if (!bit)
+		return;
 	bit->set = true;
 }
 
@@ -1027,6 +1029,8 @@ static const void *lib_vrf_lookup_next(struct nb_cb_lookup_entry_args *args)
 
 	strlcpy(vrfkey.name, vrfname, sizeof(vrfkey.name));
 	vrf = RB_FIND(vrf_name_head, &vrfs_by_name, &vrfkey);
+	if (!vrf)
+		return NULL;
 	if (!strcmp(vrf->name, vrfname))
 		vrf = RB_NEXT(vrf_name_head, vrf);