From 1863e4d6edb205317864a7e2e64fbcfb51731dac Mon Sep 17 00:00:00 2001 From: jessefaler Date: Fri, 27 Mar 2026 21:18:50 -0500 Subject: [PATCH] fix(parser): return error for unknown parser type Previously, if the parser type did not match any valid types, Parse would silently do nothing and return nil as if it succeeded. This made it easy to miss typos or invalid parser types. Now, an unknown parser type will return an error, making it easier to catch mistakes. --- parser/parser.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/parser/parser.go b/parser/parser.go index e7c98b3b2..3f3d699c6 100644 --- a/parser/parser.go +++ b/parser/parser.go @@ -215,7 +215,10 @@ func (f *ConfigurationFile) Parse(file ufs.File) error { err = f.parseIniFile(file) case Xml: err = f.parseXmlFile(file) + default: + return errors.Errorf("parser: unknown parser type %q", f.Parser) } + return err }