Skip to content

Commit 2ba8dee

Browse files
authored
Merge pull request #28 from pubref/improve_conflict_message
Improve conflict error message and update findbugs dep
2 parents 4e0325d + 2356f75 commit 2ba8dee

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

WORKSPACE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ csharp_repositories(use_local_mono = False)
4848

4949
git_repository(
5050
name = "org_pubref_rules_node",
51-
commit = "d93a80ac4920c52da8adccbca66a3118a27018fd", # Oct 2, 2016
51+
commit = "85b720f3d4299b0a1b9c7771c023352e9182045f", # Oct 10, 2016
5252
remote = "https://github.com/pubref/rules_node.git",
5353
)
5454

@@ -154,6 +154,6 @@ go_proto_library(
154154
new_git_repository(
155155
name = "com_github_googleapis_googleapis",
156156
build_file_content = GOOGLEAPIS_BUILD_FILE,
157-
commit = "60c2f9c8d012db35a65539e30fb6364c36f2e96b",
157+
commit = "13ac2436c5e3d568bd0e938f6ed58b77a48aba15",
158158
remote = "https://github.com/googleapis/googleapis.git",
159159
)

java/deps.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ DEPS = {
2020

2121
"com_google_code_findbugs_jsr305": {
2222
"rule": "maven_jar",
23-
"artifact": "com.google.code.findbugs:jsr305:jar:3.0.0",
24-
"sha1": "5871fb60dc68d67da54a663c3fd636a10a532948",
23+
"artifact": "com.google.code.findbugs:jsr305:jar:3.0.1",
24+
"sha1": "f7be08ec23c21485b9b5a1cf1654c2ec8c58168d",
2525
},
2626

2727
"com_google_guava_guava": {

protobuf/internal/require.bzl

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,12 @@ def _needs_install(name, dep, hkeys=["sha256", "sha1", "tag"], verbose=0):
1313
actual = existing_rule.get(hkey)
1414
if expected:
1515
if expected != actual:
16-
fail("Workspace %s exists but %s=%s did not match " +
17-
"the required value (%s). Either remove it from " +
18-
"your WORKSPACE or exclude it from loading."
19-
% (name, hkey, actual, expected))
16+
msg = """
17+
An existing {0} rule '{1}' was already loaded with a {2} value of '{3}'. Refusing to overwrite this with the requested value ('{4}').
18+
Either remove the pre-existing rule from your WORKSPACE or exclude it from loading by rules_protobuf.
19+
""".format(existing_rule["kind"], name, hkey, actual, expected)
20+
21+
fail(msg)
2022
else:
2123
if verbose > 1: print("Skip reload %s: %s = %s" % (name, hkey, actual))
2224
return False

0 commit comments

Comments
 (0)