Adds nodejs support.

Author: pcj

.travis.yml

@@ -6,7 +6,7 @@ os:
  # - osx
 
 env:
-  - V=HEAD URL=http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=linux-x86_64/lastSuccessfulBuild/artifact/output/ci/bazel--installer.sh FLAGS='--worker_verbose --strategy=Javac=worker --strategy=JsChecker=worker'
+  - V=0.3.2rc3 URL=https://storage.googleapis.com/bazel/0.3.2/rc3/bazel-0.3.2rc3-installer-linux-x86_64.sh FLAGS=''
   - V=0.3.1 URL=https://github.com/bazelbuild/bazel/releases/download/0.3.1/bazel-0.3.1-installer-linux-x86_64.sh FLAGS=''
 
 before_install:

README.md

@@ -47,7 +47,7 @@ of this project are to:
 | [Go (gogo)](gogo)            | [gogo_proto_compile](gogo#gogo_proto_compile) | [gogo_proto_library](gogo#gogo_proto_library) | [v1.0.0](https://github.com/grpc/grpc-go/releases/tag/v1.0.0) |
 | [gRPC gateway](grpc_gateway) | [grpc_gateway_proto_compile](grpc_gateway#grpc_gateway_proto_compile)<br/>[grpc_gateway_swagger_compile](grpc_gateway#grpc_gateway_swagger_compile)   | [grpc_gateway_proto_library](grpc_gateway#grpc_gateway_proto_library)<br/>[grpc_gateway_binary](grpc_gateway#grpc_gateway_binary) | [v1.0.0](https://github.com/grpc/grpc-go/releases/tag/v1.0.0) |
 | [Java](java)                 | [java_proto_compile](java#java_proto_compile) | [java_proto_library](java#java_proto_library) | [v1.0.1](https://github.com/grpc/grpc-java/releases/tag/v1.0.1) |
-| [Node](node)                 | [node_proto_compile](js#node_proto_compile) |           | <sup>4</sup> |
+| [Node](node)                 | [node_proto_compile](js#node_proto_compile) | [node_proto_library](js#node_proto_library)          | [1.0.0](https://www.npmjs.com/package/grpc) |
 | [Objective-C](objc) | [objc_proto_compile](objc#objc_proto_compile) | [objc_proto_library](objc#objc_proto_library) <sup>5</sup> | <sup>4</sup> |
 | [Python](python)             | [py_proto_compile](python#py_proto_compile)         |           | <sup>4</sup> |
 | [Ruby](ruby)                 | [ruby_proto_compile](ruby#ruby_proto_compile)          |           | <sup>4</sup> |
@@ -112,6 +112,7 @@ to load before the `*_proto_repositories()` function is invoked:
 | grpc_gateway_proto_repositories | [rules_go](https://github.com/bazelbuild/rules_go) |
 | closure_proto_repositories | [rules_closure](https://github.com/bazelbuild/rules_closure) |
 | csharp_proto_repositories | [rules_dotnet](https://github.com/bazelbuild/rules_dotnet) |
+| node_proto_repositories | [rules_node](https://github.com/pubref/rules_node) |
 
 If you're only interested in the `proto_compile` rule and not any
 language-specific rules, just load the generic `proto_repositories`

WORKSPACE

@@ -30,7 +30,7 @@ load("@io_bazel_rules_closure//closure:defs.bzl", "closure_repositories")
 closure_repositories()
 
 # ================================================================
-# csharp_proto_library support requires rules_dotnet (fork)
+# csharp_proto_library support requires rules_dotnet (forked)
 # ================================================================
 
 git_repository(
@@ -40,9 +40,27 @@ git_repository(
 )
 
 load("@io_bazel_rules_dotnet//dotnet:csharp.bzl", "csharp_repositories")
-
 csharp_repositories(use_local_mono = False)
 
+
+# ================================================================
+# node_proto_library support requires rules_node
+# ================================================================
+
+# local_repository(
+#     name = "org_pubref_rules_node",
+#     path = "/Users/pcj/github/rules_node",
+# )
+
+git_repository(
+    name = "org_pubref_rules_node",
+    remote = "https://github.com/pubref/rules_node.git",
+    commit = "d93a80ac4920c52da8adccbca66a3118a27018fd", # Oct 2, 2016
+)
+
+load("@org_pubref_rules_node//node:rules.bzl", "node_repositories")
+node_repositories()
+
 # ================================================================
 # Specific Languages Support
 # ================================================================
@@ -53,6 +71,9 @@ proto_repositories()
 load("//cpp:rules.bzl", "cpp_proto_repositories")
 cpp_proto_repositories()
 
+load("//csharp:rules.bzl", "csharp_proto_repositories")
+csharp_proto_repositories()
+
 load("//java:rules.bzl", "java_proto_repositories", "nano_proto_repositories")
 java_proto_repositories()
 nano_proto_repositories()
@@ -63,11 +84,11 @@ go_proto_repositories()
 load("//gogo:rules.bzl", "gogo_proto_repositories")
 gogo_proto_repositories()
 
-load("//csharp:rules.bzl", "csharp_proto_repositories")
-csharp_proto_repositories()
+load("//grpc_gateway:rules.bzl", "grpc_gateway_proto_repositories")
+grpc_gateway_proto_repositories()
+
+load("//node:rules.bzl", "node_proto_repositories")
+node_proto_repositories()
 
 load("//objc:rules.bzl", "objc_proto_repositories")
 objc_proto_repositories()
-
-load("//grpc_gateway:rules.bzl", "grpc_gateway_proto_repositories")
-grpc_gateway_proto_repositories()

cpp/BUILD

@@ -11,7 +11,7 @@ proto_language(
     supports_grpc = True,
     grpc_file_extensions = [".grpc.pb.h", ".grpc.pb.cc"],
     grpc_plugin = "//external:protoc_gen_grpc_cpp",
-    grpc_plugin_name = "grpc",
+    grpc_plugin_name = "grpc_cpp",
     grpc_compile_deps = [
         '@com_github_grpc_grpc//:grpc++',
     ],

examples/helloworld/node/BUILD

@@ -0,0 +1,28 @@
+load("@org_pubref_rules_node//node:rules.bzl", "node_binary")
+
+# Server works, but not the the client (for reasons I dont yet
+# understand)
+
+node_binary(
+    name = "client",
+    main = "greeter_client.js",
+    deps = [
+        "//examples/helloworld/proto:node",
+    ],
+    modules = [
+        "@npm_protobuf_stack//:modules",
+        "@npm_grpc//:modules",
+    ],
+)
+
+node_binary(
+    name = "server",
+    main = "greeter_server.js",
+    deps = [
+        "//examples/helloworld/proto:node",
+    ],
+    modules = [
+        "@npm_protobuf_stack//:modules",
+        "@npm_grpc//:modules",
+    ],
+)

examples/helloworld/node/greeter_client.js

@@ -0,0 +1,34 @@
+const fs = require('fs')
+const path = require('path')
+const jspb = require('google-protobuf');
+const grpc = require('grpc');
+const messages = require('examples-helloworld-proto-node');
+const services_path = path.dirname(require.resolve('examples-helloworld-proto-node'));
+const services = require(services_path + '/helloworld_grpc_pb');
+
+function main() {
+  console.log("Running main");
+  var cred = grpc.credentials.createInsecure()
+  console.log(cred.constructor.classname)
+  console.log("grpc.credentials: " + cred)
+  var client = new services.GreeterClient('localhost:50051', cred);
+  var user;
+  if (process.argv.length >= 3) {
+    user = process.argv[2];
+  } else {
+    user = 'world';
+  }
+
+  client.sayHello(request, function(err, response) {
+    console.log('Greeting:', response.getMessage());
+  });
+
+
+  // var user = "Foo";
+  // var request = new messages.HelloRequest();
+  // request.setName(user);
+  // console.log("Hello " + request.getName());
+
+}
+
+main();

examples/helloworld/node/greeter_server.js

@@ -0,0 +1,28 @@
+const path = require('path')
+const messages = require('examples-helloworld-proto-node');
+const services_path = path.dirname(require.resolve('examples-helloworld-proto-node'));
+const services = require(services_path + '/helloworld_grpc_pb');
+
+var grpc = require('grpc');
+
+/**
+ * Implements the SayHello RPC method.
+ */
+function sayHello(call, callback) {
+  var reply = new messages.HelloReply();
+  reply.setMessage('Hello ' + call.request.getName());
+  callback(null, reply);
+}
+
+/**
+ * Starts an RPC server that receives requests for the Greeter service at the
+ * sample server port
+ */
+function main() {
+  var server = new grpc.Server();
+  server.addService(services.GreeterService, {sayHello: sayHello});
+  server.bind('0.0.0.0:50051', grpc.ServerCredentials.createInsecure());
+  server.start();
+}
+
+main();

examples/helloworld/proto/BUILD

@@ -6,6 +6,7 @@ load("//go:rules.bzl", "go_proto_library")
 load("//gogo:rules.bzl", "gogo_proto_library")
 load("//java:rules.bzl", "java_proto_library")
 load("//csharp:rules.bzl", "csharp_proto_library")
+load("//node:rules.bzl", "node_proto_library")
 
 filegroup(
     name = "protos",
@@ -44,9 +45,18 @@ cc_proto_library(
     with_grpc = True,
 )
 
+node_proto_library(
+    name = "node",
+    proto_deps = [
+        "//examples/proto:node",
+    ],
+    protos = [":protos"],
+    verbose = 0,
+    with_grpc = True,
+)
+
 java_proto_library(
     name = "java",
-    output_to_workspace = False,
     proto_deps = [
         "//examples/proto:java",
     ],
@@ -58,15 +68,14 @@ java_proto_library(
 proto_compile(
     name = "py",
     langs = ["//python"],
-    output_to_workspace = False,
     protos = [":protos"],
-    with_grpc = False,
+    with_grpc = True,
+    verbose = 1,
 )
 
 proto_compile(
     name = "ruby",
     langs = ["//ruby"],
-    output_to_workspace = False,
     protos = [":protos"],
     with_grpc = False,
 )

examples/proto/BUILD

@@ -6,7 +6,7 @@ load("//csharp:rules.bzl", "csharp_proto_compile", "csharp_proto_library")
 load("//go:rules.bzl", "go_proto_library")
 load("//java:rules.bzl", "java_proto_library")
 load("//closure:rules.bzl", "closure_proto_library")
-load("//node:rules.bzl", "node_proto_compile")
+load("//node:rules.bzl", "node_proto_compile", "node_proto_library")
 load("//objc:rules.bzl", "objc_proto_library")
 
 filegroup(
@@ -47,11 +47,18 @@ csharp_proto_library(
     verbose = 0,
 )
 
+node_proto_library(
+    name = "node",
+    protos = [":protos"],
+    with_grpc = False,
+    verbose = 0,
+)
+
 # This conflicts with outputs from other rules here but demonstrates
 # how to generate multiple language outputs simultaneously.
-
+#
 # proto_compile(
-#     name = "pluri",
+#     name = "pluriproto",
 #     protos = [":protos"],
 #     langs = [
 #         "//ruby",
@@ -61,6 +68,8 @@ csharp_proto_library(
 #         "//cpp",
 #         "//objc",
 #         "//closure",
+#         "//csharp",
+#         "//go",
 #         "//node",
 #     ],
 #     verbose = 2,

node/BUILD

@@ -8,7 +8,10 @@ proto_language(
     pb_file_extensions = ["_pb.js"],
     pb_options = [
         "import_style=commonjs",
-        "error_on_name_conflict",
         "binary",
     ],
+    supports_grpc = True,
+    grpc_file_extensions = ["_grpc_pb.js"],
+    grpc_plugin = "@com_github_grpc_grpc//:grpc_node_plugin",
+    grpc_plugin_name = "grpc_node",
 )