0.3.5 with support for labels in protos attribute in (cpp,go)

Author: pcj

README.md

@@ -63,7 +63,7 @@ Require these rules your `WORKSPACE`:
 git_repository(
   name = "org_pubref_rules_protobuf",
   remote = "https://github.com/pubref/rules_protobuf",
-  tag = "v0.3.4",
+  tag = "v0.3.5",
 )
 ```
 

WORKSPACE

@@ -11,10 +11,6 @@ git_repository(
     remote = "https://github.com/bazelbuild/rules_go.git",
 )
 
-load("@io_bazel_rules_go//go:def.bzl", "go_repositories")
-
-go_repositories()
-
 # ================================================================
 # Load self
 # ================================================================

bzl/cpp/README.md

@@ -38,8 +38,15 @@ cc_proto_library(
 
 ```sh
 $ bazel build :protolib
+$ bazel build --spawn_strategy=standalone :protolib
 ```
 
+> Note: there are some remaining issues with grpc++ compiling on linux
+> that may require disabling the sandbox via the
+> `--spawn_strategy=standalone` build option. See
+> https://github.com/pubref/rules_protobuf/issues/7
+
+
 When using the compiled library in other rules, `#include` the
 generated files relative to the `WORKSPACE` root.  For example, the
 `//examples/helloworld/proto/helloworld.proto` functions can be loaded

bzl/java/rules.bzl

@@ -25,6 +25,7 @@ def java_proto_library(
   args = {}
   args["name"] = name + "_pb"
   args["deps"] = deps
+  args["copy_protos_to_genfiles"] = False
   args["protos"] = protos
   args["verbose"] = verbose
   args["imports"] = imports

bzl/protoc.bzl

@@ -108,6 +108,7 @@ def _get_gendir(ctx):
     outdir = ctx.var["GENDIR"]
   else:
     outdir = ctx.var["BINDIR"]
+
   return outdir + "/" + ctx.label.package
 
 
@@ -120,6 +121,7 @@ def _execute_rule(self):
   for src in self["srcs"]:
     srcfiles += [src.path]
 
+
   #self["args"] += ["--descriptor_set_out=%s" % (descriptor_set_file.path)]
 
   arguments = list(set(self["args"] + ["-I" + i for i in self["imports"]] + srcfiles))

bzl/rules.bzl

@@ -1,6 +1,7 @@
 load("//bzl:repositories.bzl", "REPOSITORIES")
 load("//bzl:classes.bzl", "CLASSES")
 load("//bzl:util.bzl", "require", "invoke")
+load("@io_bazel_rules_go//go:def.bzl", "go_repositories")
 
 def protobuf_repositories(
     with_protoc = True,
@@ -47,6 +48,9 @@ def protobuf_repositories(
   if with_grpc_gateway:
     with_go = True
 
+  if with_go:
+    go_repositories()
+
   if with_cpp:
     classes += ["cpp"]
   if with_python: