GH-55: Force overwrite if the skip flag is not set (GH-56)

* Overwrite the existing files by default
* Replace the `filter` with list comprehension
* Add unit test for checking the overwrite

Author: ArtyomVancyan

src/thumbnails/__init__.py

@@ -22,7 +22,7 @@
 from .thumbnail import ThumbnailVTT
 from .thumbnail import register_thumbnail
 
-__version__ = "0.1.3"
+__version__ = "0.1.4"
 __all__ = (
     "Generator",
     "Thumbnail",

src/thumbnails/generator.py

@@ -4,8 +4,6 @@
 import os
 import re
 
-import click
-
 from .constants import DEFAULT_BASE
 from .constants import DEFAULT_COMPRESS
 from .constants import DEFAULT_FORMAT
@@ -48,13 +46,8 @@ def worker(video, fmt, base, skip, output):
         thumbnail.generate()
 
     def generate(self):
-        self.inputs = dict(zip(
-            map(lambda i: metadata_path(i, self.output, self.format), self.inputs),
-            filter(lambda i: re.match(r"^.*\.(?:(?!png|vtt|json).)+$", i), self.inputs),
-        ))
-
-        if not self.skip and any(map(os.path.exists, self.inputs.keys())):
-            self.skip = not click.confirm("Do you want to overwrite already existing files?")
+        self.inputs = [file for file in self.inputs if re.match(r"^.*\.(?:(?!png|vtt|json).)+$", file)]
+        self.inputs = dict(zip(map(lambda i: metadata_path(i, self.output, self.format), self.inputs), self.inputs))
 
         with concurrent.futures.ThreadPoolExecutor() as executor:
             videos = executor.map(

tests/test_cli.py

@@ -37,6 +37,11 @@ def test_cli_only_files(tmp_media):
     assert os.path.exists(os.path.join(tmp_media, "avi", "video.vtt"))
 
 
+def test_cli_overwrite_files(tmp_media):
+    test_cli_only_files(tmp_media)
+    test_cli_only_files(tmp_media)
+
+
 def test_cli_only_directories(tmp_media):
     execute_cli(
         os.path.join(tmp_media, "avi"),