Skip to content

Document Twisted support#13

Draft
altendky wants to merge 3 commits into
python-trio:masterfrom
altendky:altendky-just_twisted
Draft

Document Twisted support#13
altendky wants to merge 3 commits into
python-trio:masterfrom
altendky:altendky-just_twisted

Conversation

@altendky

@altendky altendky commented May 16, 2020

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Oct 29, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (0cfdab8) to head (1a1459f).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files           4        4           
  Lines          86       86           
  Branches       17       15    -2     
=======================================
  Hits           83       83           
  Misses          2        2           
  Partials        1        1           
Files with missing lines Coverage Δ
sniffio/_impl.py 90.90% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cclauss

cclauss commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Please resolve git conflicts.

@altendky

altendky commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

"WIP for"... ha! that old... updating to use 'draft' instead.

@altendky altendky marked this pull request as draft March 6, 2026 14:28
@altendky altendky changed the title [WIP] Document Twisted support Document Twisted support Mar 6, 2026
@altendky

altendky commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

fwiw, twisted doesn't support sniffio yet. this was a place holder.

twisted/twisted#1263
twisted/twisted#12571

@cclauss

cclauss commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

A placeholder for:

@altendky

altendky commented Mar 7, 2026

Copy link
Copy Markdown
Member Author

these certainly do all relate, though i don't recall all the details at this point. mostly we need to figure out the path in twisted. they are open to but not positive about this. regardless of where it's implemented it's dedicated functionality that is doing low level observations. i can see arguments for twisted not wanting to deal with this for the sake of not-twisted, though sure, it's easy to argue that cross compatibility via sniffio/anyio etc is good for everyone. and we did not want to implement the detection within sniffio due to the complexity of maintaining sensitive tooling outside of twisted repo where breaking changes would only be detected later.

the way i see it is that regardless, this detection code is going to be 'ugly'... and as such, it's had a hard time finding a home. also i moved jobs years ago away from using twisted, and now have moved jobs again away from using python, so my drive to see this through waned.

but, here i am... maybe i'll take another pass on the twisted PRs today. this explanation is just meant to be that, an explanation to share understanding. no frustration or passing the buck.

thanks for your interest in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants