fix(tests): making test_read_only test less flaky

Author: StephenSorriaux

kazoo/tests/test__connection.py kazoo/tests/test_connection.pykazoo/tests/test__connection.py renamed to kazoo/tests/test_connection.py

@@ -258,7 +258,7 @@ def back(state):
 class TestReadOnlyMode(KazooTestCase):
     def setUp(self):
         os.environ["ZOOKEEPER_LOCAL_SESSION_RO"] = "true"
-        self.setup_zookeeper(read_only=True)
+        self.setup_zookeeper()
         skip = False
         if CI_ZK_VERSION and CI_ZK_VERSION < (3, 4):
             skip = True
@@ -278,8 +278,10 @@ def tearDown(self):
     def test_read_only(self):
         from kazoo.exceptions import NotReadOnlyCallError
         from kazoo.protocol.states import KeeperState
+        from kazoo.retry import KazooRetry
 
-        client = self.client
+        conn_retry = KazooRetry(max_tries=50, delay=0.5, max_delay=180)
+        client = self._get_client(connection_retry=conn_retry, read_only=True)
         states = []
         ev = threading.Event()
 
@@ -289,6 +291,7 @@ def listen(state):
             if client.client_state == KeeperState.CONNECTED_RO:
                 ev.set()
 
+        client.start()
         try:
             # stopping both nodes at the same time
             # else the test seems flaky when on CI hosts
@@ -303,12 +306,11 @@ def listen(state):
                 thread.start()
             for thread in zk_stop_threads:
                 thread.join()
-            ev.wait(15)
-            assert ev.is_set()
-            assert client.client_state == KeeperState.CONNECTED_RO
-
+            #ev.wait(15)
             # Test read only command
             assert client.get_children("/") == []
+            assert ev.is_set()
+            assert client.client_state == KeeperState.CONNECTED_RO
 
             # Test error with write command
             with pytest.raises(NotReadOnlyCallError):

pyproject.toml

@@ -114,11 +114,11 @@ module = [
     'kazoo.testing.common',
     'kazoo.testing.harness',
     'kazoo.tests.conftest',
-    'kazoo.tests.test__connection',
     'kazoo.tests.test_barrier',
     'kazoo.tests.test_build',
     'kazoo.tests.test_cache',
     'kazoo.tests.test_client',
+    'kazoo.tests.test_connection',
     'kazoo.tests.test_counter',
     'kazoo.tests.test_election',
     'kazoo.tests.test_eventlet_handler',

tox.ini

@@ -36,7 +36,7 @@ allowlist_externals =
 commands =
     sasl: {toxinidir}/init_krb5.sh {envtmpdir}/kerberos \
         {toxinidir}/ensure-zookeeper-env.sh \
-        pytest {posargs: -ra -v --cov-report=xml --cov=kazoo kazoo/tests}
+        pytest {posargs: -ra -v --cov-report=xml --cov=kazoo kazoo/tests/test_connection.py}
 
 [testenv:build]