From 3092e4cbc28ed849a4e95590f8c2d6f747456b9e Mon Sep 17 00:00:00 2001 From: Elton Chang Date: Mon, 29 Jun 2026 23:47:05 -0700 Subject: [PATCH 1/3] Add walrus allow-redefinition test --- test-data/unit/check-redefine2.test | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test-data/unit/check-redefine2.test b/test-data/unit/check-redefine2.test index 2af6959dd21a6..83a17ec3089e4 100644 --- a/test-data/unit/check-redefine2.test +++ b/test-data/unit/check-redefine2.test @@ -333,6 +333,19 @@ def f3() -> None: reveal_type(x) # N: Revealed type is "builtins.int | builtins.str" reveal_type(x) # N: Revealed type is "builtins.int | builtins.str" +[case testNewRedefineAssignmentExpressionComprehensions] +# flags: --allow-redefinition +def f() -> None: + x = 0 + xs = [x := ""] + reveal_type(xs) # N: Revealed type is "builtins.list[builtins.str]" + reveal_type(x) # N: Revealed type is "builtins.str" + + x = 1.0 + reveal_type(x) # N: Revealed type is "builtins.float" + +[builtins fixtures/list.pyi] + [case testNewRedefineOperatorAssignment] # flags: --allow-redefinition class D: pass From aeba7ccd533a34194c8f212a8542d60d6e1a723c Mon Sep 17 00:00:00 2001 From: Elton Chang <80650461+EltonChang1@users.noreply.github.com> Date: Tue, 30 Jun 2026 03:21:50 -0400 Subject: [PATCH 2/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- test-data/unit/check-redefine2.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-data/unit/check-redefine2.test b/test-data/unit/check-redefine2.test index 83a17ec3089e4..5d94264a9a24f 100644 --- a/test-data/unit/check-redefine2.test +++ b/test-data/unit/check-redefine2.test @@ -337,7 +337,7 @@ def f3() -> None: # flags: --allow-redefinition def f() -> None: x = 0 - xs = [x := ""] + xs = [x := "" for _ in [0]] reveal_type(xs) # N: Revealed type is "builtins.list[builtins.str]" reveal_type(x) # N: Revealed type is "builtins.str" From cf526535558b0c441fa80b16c381c346e36e4000 Mon Sep 17 00:00:00 2001 From: Elton Chang Date: Tue, 30 Jun 2026 01:59:06 -0700 Subject: [PATCH 3/3] Fix walrus comprehension test expectation --- test-data/unit/check-redefine2.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-data/unit/check-redefine2.test b/test-data/unit/check-redefine2.test index 5d94264a9a24f..86ac00f6fc4b7 100644 --- a/test-data/unit/check-redefine2.test +++ b/test-data/unit/check-redefine2.test @@ -339,7 +339,7 @@ def f() -> None: x = 0 xs = [x := "" for _ in [0]] reveal_type(xs) # N: Revealed type is "builtins.list[builtins.str]" - reveal_type(x) # N: Revealed type is "builtins.str" + reveal_type(x) # N: Revealed type is "builtins.int" x = 1.0 reveal_type(x) # N: Revealed type is "builtins.float"