test: fix UI assertions, path checks, and file read mock

Author: zodiacfireworks

tests/unit/screens/test_loading.py

@@ -41,13 +41,14 @@ async def test_loading_screen_error(self, mock_get):
                 if app.screen.query_one("#loading-actions").display:
                     break
             assert app.screen.query_one("#loading-actions").display is True
-            assert "unexpected error" in str(app.screen.query_one("#result-msg").render())
+            assert "An unexpected error" in str(app.screen.query_one("#result-msg").render())
 
             # Test loading-back
             await pilot.click("#loading-back")
             await pilot.pause()
             # Popped screen
-
+            from edit_python_pe.screens.language import LanguageScreen
+            assert isinstance(app.screen, LanguageScreen)
     @pytest.mark.asyncio
     @patch("edit_python_pe.screens.loading.get_repo")
     async def test_loading_screen_quit(self, mock_get):

tests/unit/screens/test_save_loading.py

@@ -87,7 +87,7 @@ async def test_save_loading_error(self, mock_create, mock_save_params):
                     break
 
             assert app.screen.query_one("#loading-actions").display is True
-            assert "Some error" in str(app.screen.query_one("#result-msg").render())
+            assert "An error occurred while" in str(app.screen.query_one("#result-msg").render())
 
             # Back button should be visible and work
             await pilot.click("#btn-back")
@@ -115,7 +115,7 @@ async def test_save_loading_github_error(self, mock_create, mock_save_params):
                 if app.screen.query_one("#loading-actions").display:
                     break
 
-            assert "Specific auth error" in str(
+            assert "An error occurred while" in str(
                 app.screen.query_one("#result-msg").render()
             )
 

tests/unit/test_file_io.py

@@ -45,12 +45,10 @@ def test_write_authors_file(self):
     def test_read_file(self):
         file_path = "/tmp/testfile.txt"
         expected_content = "Hello, world!"
-        with patch("builtins.open", MagicMock()) as mock_open:
-            mock_open.return_value.__enter__.return_value.read.return_value = (
-                expected_content
-            )
+        from unittest.mock import mock_open
+        with patch("builtins.open", mock_open(read_data=expected_content)) as mock_open_file:
             result = _read_file(file_path)
-            mock_open.assert_called_with(file_path, encoding="utf-8")
+            mock_open_file.assert_called_with(file_path, encoding="utf-8")
             assert result == expected_content
 
     def test_append_file(self):

tests/unit/test_markdown_builder.py

@@ -22,7 +22,8 @@ def test_create_member_file(self):
             mock_write_file.assert_called_once_with(file_content, file_path)
             assert name_file.startswith(expected_filename_prefix)
             assert name_file.endswith(".md")
-            assert "blog/members/" in file_path
+            import os
+            assert os.path.join("blog", "members") in file_path
             assert file_path.endswith(name_file)
 
         # Test with current_file provided