Skip to content

Commit 3449966

Browse files
authored
Merge pull request #365 from YangSen-qn/develop
up log quality add target_key and target_bucket
2 parents d6b8ba1 + 593becc commit 3449966

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

QiniuSDK/Collect/QNReportItem.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ extern NSString *const QNReportBlockKeyClientTime;
108108
extern NSString *const QNReportQualityKeyLogType;
109109
extern NSString *const QNReportQualityKeyUpTime;
110110
extern NSString *const QNReportQualityKeyResult;
111+
extern NSString *const QNReportQualityKeyTargetBucket;
112+
extern NSString *const QNReportQualityKeyTargetKey;
111113
extern NSString *const QNReportQualityKeyTotalElapsedTime;
112114
extern NSString *const QNReportQualityKeyRequestsCount;
113115
extern NSString *const QNReportQualityKeyRegionsCount;

QiniuSDK/Collect/QNReportItem.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,10 @@ - (NSString *)qualityResult{
216216

217217
//MARK:-- 上传质量统计
218218
NSString * const QNReportQualityKeyLogType = @"log_type";
219-
NSString *const QNReportQualityKeyUpTime = @"up_time";
219+
NSString * const QNReportQualityKeyUpTime = @"up_time";
220220
NSString * const QNReportQualityKeyResult = @"result";
221+
NSString * const QNReportQualityKeyTargetBucket = @"target_bucket";
222+
NSString * const QNReportQualityKeyTargetKey = @"target_key";
221223
NSString * const QNReportQualityKeyTotalElapsedTime = @"total_elapsed_time";
222224
NSString * const QNReportQualityKeyRequestsCount = @"requests_count";
223225
NSString * const QNReportQualityKeyRegionsCount = @"regions_count";

QiniuSDK/Storage/QNUploadManager.m

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ + (void)complete:(NSString *)token
393393
taskMetrics:(QNUploadTaskMetrics *)taskMetrics
394394
complete:(QNUpCompletionHandler)completionHandler {
395395

396-
[QNUploadManager reportQuality:responseInfo taskMetrics:taskMetrics token:token];
396+
[QNUploadManager reportQuality:key responseInfo:responseInfo taskMetrics:taskMetrics token:token];
397397

398398
QNAsyncRunInMain(^{
399399
if (completionHandler) {
@@ -404,16 +404,21 @@ + (void)complete:(NSString *)token
404404

405405

406406
//MARK:-- 统计quality日志
407-
+ (void)reportQuality:(QNResponseInfo *)info
407+
+ (void)reportQuality:(NSString *)key
408+
responseInfo:(QNResponseInfo *)responseInfo
408409
taskMetrics:(QNUploadTaskMetrics *)taskMetrics
409410
token:(NSString *)token{
410411

412+
QNUpToken *upToken = [QNUpToken parse:token];
411413
QNUploadTaskMetrics *taskMetricsP = taskMetrics ?: [QNUploadTaskMetrics emptyMetrics];
412414

413415
QNReportItem *item = [QNReportItem item];
414416
[item setReportValue:QNReportLogTypeQuality forKey:QNReportQualityKeyLogType];
415417
[item setReportValue:@([[NSDate date] timeIntervalSince1970]) forKey:QNReportQualityKeyUpTime];
416-
[item setReportValue:info.qualityResult forKey:QNReportQualityKeyResult];
418+
[item setReportValue:responseInfo.qualityResult forKey:QNReportQualityKeyResult];
419+
[item setReportValue:upToken.bucket forKey:QNReportQualityKeyTargetBucket];
420+
[item setReportValue:key forKey:QNReportQualityKeyTargetKey];
421+
[item setReportValue:taskMetricsP.totalElapsedTime forKey:QNReportQualityKeyTotalElapsedTime];
417422
[item setReportValue:taskMetricsP.totalElapsedTime forKey:QNReportQualityKeyTotalElapsedTime];
418423
[item setReportValue:taskMetricsP.requestCount forKey:QNReportQualityKeyRequestsCount];
419424
[item setReportValue:taskMetricsP.regionCount forKey:QNReportQualityKeyRegionsCount];

0 commit comments

Comments
 (0)