Merge pull request #8 from longbai/filerecorder_nil_error

file recorder nil error check

Author: longbai

QiniuSDK/Recorder/QNFileRecorder.m

@@ -35,8 +35,12 @@ + (instancetype)fileRecorderWithFolder:(NSString *)directory
 + (instancetype)fileRecorderWithFolder:(NSString *)directory
                              encodeKey:(BOOL)encode
                                  error:(NSError *__autoreleasing *)perror {
-	[[NSFileManager defaultManager] createDirectoryAtPath:directory withIntermediateDirectories:YES attributes:nil error:perror];
-	if (*perror != nil) {
+	NSError *error;
+	[[NSFileManager defaultManager] createDirectoryAtPath:directory withIntermediateDirectories:YES attributes:nil error:&error];
+	if (error != nil) {
+		if (perror) {
+			*perror = error;
+		}
 		return nil;
 	}
 

QiniuSDKTests/QNFileRecorderTest.m

@@ -38,6 +38,16 @@ - (void)setUp {
 #endif
 }
 
+- (void)testInit {
+	NSError *error = nil;
+	[QNFileRecorder fileRecorderWithFolder:[NSTemporaryDirectory() stringByAppendingString:@"qiniutest"] error:&error];
+	XCTAssert(error == nil, @"Pass");
+	[QNFileRecorder fileRecorderWithFolder:@"/qiniutest" error:&error];
+	NSLog(@"file recorder %@", error);
+	XCTAssert(error != nil, @"Pass");
+	[QNFileRecorder fileRecorderWithFolder:@"/qiniutest" error:nil];
+}
+
 - (void)template:(int)size pos:(float)pos {
 	NSURL *tempFile = [QNTempFile createTempfileWithSize:size * 1024];
 	NSString *keyUp = [NSString stringWithFormat:@"r-%dk", size];