From ccff0492a4d5ef11f9329896b2521af3bff642d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Je=CC=81ro=CC=82me=20Mare?= Date: Thu, 17 Jan 2019 21:20:22 +0100 Subject: [PATCH] feat: devserver shall be capable to open app not only in default system browser #2960 --- lib/dev-server.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/dev-server.js b/lib/dev-server.js index da4abf2..5f23948 100644 --- a/lib/dev-server.js +++ b/lib/dev-server.js @@ -8,9 +8,9 @@ const let alreadyNotified = false -function openBrowser (url) { +function openBrowser (url, options = {}) { const opn = require('opn') - opn(url) + opn(url, options) } module.exports = class DevServer { @@ -53,7 +53,8 @@ module.exports = class DevServer { alreadyNotified = true if (cfg.devServer.open && ['spa', 'pwa'].includes(cfg.ctx.modeName)) { - openBrowser(cfg.build.APP_URL) + const browser = cfg.browser || {} + openBrowser(cfg.build.APP_URL, browser) } }) }) @@ -241,7 +242,8 @@ module.exports = class DevServer { server.listen(cfg.devServer.port, cfg.devServer.host, () => { resolve() if (cfg.devServer.open) { - openBrowser(cfg.build.APP_URL) + const browser = cfg.browser || {} + openBrowser(cfg.build.APP_URL, browser) } }) })