added unauthorized notification to manager

Signed-off-by: James Hall <james.hall@vmlyr.com>

Author: quickthyme

Sources/WebRequest/Manager/WebRequestManager.swift

@@ -1,8 +1,17 @@
 import Foundation
 
+internal protocol WRNotificationCenterInterface {
+    func post(_ notification: Notification)
+}
+extension NotificationCenter: WRNotificationCenterInterface {}
+
 public class WebRequestManager: WebRequestManaging {
 
-    typealias ErrorCode = WebRequest.Result.ErrorCode
+    public typealias ErrorCode = WebRequest.Result.ErrorCode
+
+    internal var UnauthorizedResponseNotification: Notification {
+        return Notification(name: WebRequestUnauthorizedResponseNotification, object: nil, userInfo: nil)
+    }
 
     private let accessQueue: DispatchQueue = DispatchQueue(label: "WebRequestQueue.accessQueue",
                                                            qos: .background,
@@ -32,6 +41,8 @@ public class WebRequestManager: WebRequestManaging {
 
     public var applySession: SessionApplier!
 
+    internal lazy var notificationCenter: WRNotificationCenterInterface = NotificationCenter.default
+
     public static let shared = WebRequestManager()
 
     private init() { /**/ }
@@ -119,6 +130,7 @@ private extension WebRequestManager {
                 .filter { $0.state == .ready || $0.state == .unauthorized }
 
             guard let session = self.sessionProvider?.current else {
+                notificationCenter.post(UnauthorizedResponseNotification)
                 if let anyRequest = readyRequests.first?.originalRequest {
                     self.fail(request: anyRequest, withStatus: 401)
                 }
@@ -148,6 +160,10 @@ private extension WebRequestManager {
                 return
         }
 
+        if wrapper.state == .unauthorized {
+            notificationCenter.post(UnauthorizedResponseNotification)
+        }
+
         try wrapper.originalRequest.completion?(actualResult, wrapper.originalRequest)
     }
 

Sources/WebRequest/Manager/WebRequestManaging.swift

@@ -1,5 +1,7 @@
 import Foundation
 
+public let WebRequestUnauthorizedResponseNotification: Notification.Name = Notification.Name("UnauthorizedResponseNotification")
+
 public protocol WebRequestManaging {
 
     typealias SessionApplier = (WebRequest, WebRequestSession) -> (WebRequest)

Tests/WebRequestTests/Doubles/MockNotificationCenter.swift

@@ -0,0 +1,13 @@
+import Foundation
+@testable import WebRequest
+
+class MockNotificationCenter: WRNotificationCenterInterface {
+
+    var didPost: Bool = false
+    var postedNotificationName: Notification.Name? = nil
+
+    func post(_ notification: Notification) {
+        didPost = true
+        postedNotificationName = notification.name
+    }
+}

Tests/WebRequestTests/Manager/WebRequestManagerTests.swift

@@ -6,6 +6,7 @@ class WebRequestManagerTests: XCTestCase {
     var subject: WebRequestManager!
     var mockSessionProvider: MockWebRequestSessionProvider!
     var mockApplySession: WebRequestManaging.SessionApplier!
+    var mockNotificationCenter: MockNotificationCenter!
 
     var capturedRequest: WebRequest?
     var capturedSession: WebRequestSession?
@@ -27,6 +28,8 @@ class WebRequestManagerTests: XCTestCase {
         subject = WebRequestManager(sessionProvider: mockSessionProvider,
                                     applySession: mockApplySession)
 
+        mockNotificationCenter = MockNotificationCenter()
+        subject.notificationCenter = mockNotificationCenter
     }
 
     func test_begin_request_with_current_session_should_complete() {
@@ -119,9 +122,11 @@ class WebRequestManagerTests: XCTestCase {
 
         XCTAssertFalse(mockDelivery.didCall_deliver)
         XCTAssert(receivedResult!.status == StatusCode.unauthorized.rawValue)
+        XCTAssertTrue(mockNotificationCenter.didPost)
+        XCTAssertEqual(mockNotificationCenter.postedNotificationName, WebRequestUnauthorizedResponseNotification)
     }
 
-    func test_begin_request_when_getting_unauthorized_result_should_attempt_refresh_once_and_raise_401_if_call_fails_again() {
+    func test_begin_request_when_getting_unauthorized_result_should_attempt_refresh_once_then_raise_401_and_post_notification_if_call_fails_again() {
         var receivedResult: WebRequest.Result? = nil
         let expectComplete = expectation(description: "should refresh")
 
@@ -147,5 +152,7 @@ class WebRequestManagerTests: XCTestCase {
         XCTAssertTrue(mockDelivery.didCall_deliver)
         XCTAssertEqual(mockSessionProvider.timesCalled_refresh, 1)
         XCTAssert(receivedResult!.status == StatusCode.unauthorized.rawValue)
+        XCTAssertTrue(mockNotificationCenter.didPost)
+        XCTAssertEqual(mockNotificationCenter.postedNotificationName, WebRequestUnauthorizedResponseNotification)
     }
 }

WebRequest.xcodeproj/project.pbxproj

@@ -18,6 +18,7 @@
 		DC8F2B6F223359D400277F70 /* HTTPWebRequestDelivery.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCB68C6E2022EC9E00973778 /* HTTPWebRequestDelivery.swift */; };
 		DC8F2B70223359D400277F70 /* JSONWebRequestDelivery.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCB68C6F2022EC9E00973778 /* JSONWebRequestDelivery.swift */; };
 		DC8F2B71223359D400277F70 /* MultipartFormUploadWebRequestDelivery.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCB68C702022EC9E00973778 /* MultipartFormUploadWebRequestDelivery.swift */; };
+		DCAAB91323676AB4000B3463 /* MockNotificationCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCAAB91223676AB4000B3463 /* MockNotificationCenter.swift */; };
 		DCB68C5E2022CCE500973778 /* WebRequestTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCB68C5D2022CCE500973778 /* WebRequestTests.swift */; };
 		DCB68C6B2022CE6800973778 /* TestHTTPServer.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCB68C6A2022CE6800973778 /* TestHTTPServer.swift */; };
 		DCB68C802022EDD300973778 /* MockWebRequestDelivery.swift in Sources */ = {isa = PBXBuildFile; fileRef = DCB68C7B2022ED2200973778 /* MockWebRequestDelivery.swift */; };
@@ -64,6 +65,7 @@
 		DC0B165C2270BDA9000DA8E8 /* WebRequest+Result.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "WebRequest+Result.swift"; sourceTree = "<group>"; };
 		DC0B165E2270C43B000DA8E8 /* WebRequestEndpoint.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WebRequestEndpoint.swift; sourceTree = "<group>"; };
 		DC8F2B61223358CD00277F70 /* libWebRequest-iOS.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libWebRequest-iOS.a"; sourceTree = BUILT_PRODUCTS_DIR; };
+		DCAAB91223676AB4000B3463 /* MockNotificationCenter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockNotificationCenter.swift; sourceTree = "<group>"; };
 		DCB68C532022CCE500973778 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
 		DCB68C582022CCE500973778 /* WebRequestTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = WebRequestTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
 		DCB68C5D2022CCE500973778 /* WebRequestTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WebRequestTests.swift; sourceTree = "<group>"; };
@@ -210,6 +212,7 @@
 			isa = PBXGroup;
 			children = (
 				DCB68C852022FA8500973778 /* MockEndpoint.swift */,
+				DCAAB91223676AB4000B3463 /* MockNotificationCenter.swift */,
 				DCB68C7A2022ED2200973778 /* MockURLSession.swift */,
 				DCB68C7B2022ED2200973778 /* MockWebRequestDelivery.swift */,
 				DCBC7BA4230E346A002FBF61 /* MockWebRequestSession.swift */,
@@ -387,6 +390,7 @@
 			buildActionMask = 2147483647;
 			files = (
 				DCBC7BA3230E2CB1002FBF61 /* MockWebRequestSessionProvider.swift in Sources */,
+				DCAAB91323676AB4000B3463 /* MockNotificationCenter.swift in Sources */,
 				DCBC7B94230C7BEE002FBF61 /* BasicHTTPResultValidatorTests.swift in Sources */,
 				DCB68C812022EDD700973778 /* MockURLSession.swift in Sources */,
 				DCB68C802022EDD300973778 /* MockWebRequestDelivery.swift in Sources */,