|
| 1 | +// This Source Code Form is subject to the terms of the Mozilla Public |
| 2 | +// License, v. 2.0. If a copy of the MPL was not distributed with this |
| 3 | +// file, You can obtain one at https://mozilla.org/MPL/2.0/. |
| 4 | +// |
| 5 | +// Copyright (c) 2013-2020 VMware, Inc. or its affiliates. All rights reserved. |
| 6 | +package com.rabbitmq.integration.tests; |
| 7 | + |
| 8 | +import static org.junit.jupiter.api.Assertions.assertEquals; |
| 9 | +import static org.junit.jupiter.api.Assertions.assertThrows; |
| 10 | +import static org.junit.jupiter.api.Assertions.fail; |
| 11 | + |
| 12 | +import com.rabbitmq.jms.admin.RMQConnectionFactory; |
| 13 | +import com.rabbitmq.jms.client.message.RMQStreamMessage; |
| 14 | +import com.rabbitmq.jms.client.message.TestMessages; |
| 15 | +import com.rabbitmq.jms.util.RMQJMSException; |
| 16 | +import java.awt.Color; |
| 17 | +import java.lang.reflect.Method; |
| 18 | +import java.util.Arrays; |
| 19 | +import java.util.HashMap; |
| 20 | +import java.util.Map; |
| 21 | +import javax.jms.Queue; |
| 22 | +import javax.jms.QueueReceiver; |
| 23 | +import javax.jms.QueueSender; |
| 24 | +import javax.jms.QueueSession; |
| 25 | +import javax.jms.Session; |
| 26 | +import javax.jms.StreamMessage; |
| 27 | +import org.junit.jupiter.api.Test; |
| 28 | + |
| 29 | +public class StreamMessageSerializationIT extends AbstractITQueue { |
| 30 | + |
| 31 | + private static final String QUEUE_NAME = "test.queue." + StreamMessageSerializationIT.class.getCanonicalName(); |
| 32 | + private static final long TEST_RECEIVE_TIMEOUT = 1000; // one second |
| 33 | + private static final java.util.List<String> TRUSTED_PACKAGES = Arrays.asList("java.lang", "com.rabbitmq.jms"); |
| 34 | + |
| 35 | + @Override |
| 36 | + protected void customise(RMQConnectionFactory connectionFactory) { |
| 37 | + super.customise(connectionFactory); |
| 38 | + connectionFactory.setTrustedPackages(TRUSTED_PACKAGES); |
| 39 | + } |
| 40 | + |
| 41 | + protected void testReceiveStreamMessageWithValue(Object value) throws Exception { |
| 42 | + try { |
| 43 | + queueConn.start(); |
| 44 | + QueueSession queueSession = queueConn.createQueueSession(false, Session.DUPS_OK_ACKNOWLEDGE); |
| 45 | + Queue queue = queueSession.createQueue(QUEUE_NAME); |
| 46 | + |
| 47 | + drainQueue(queueSession, queue); |
| 48 | + |
| 49 | + QueueSender queueSender = queueSession.createSender(queue); |
| 50 | + StreamMessage message = (StreamMessage) MessageTestType.STREAM.gen(queueSession, null); |
| 51 | + |
| 52 | + // we simulate an attack from the sender by calling writeObject with a non-primitive value |
| 53 | + // (StreamMessage supports only primitive types) |
| 54 | + // the value is then sent to the destination and the consumer will have to |
| 55 | + // deserialize it and can potentially execute malicious code |
| 56 | + Method writeObjectMethod = RMQStreamMessage.class |
| 57 | + .getDeclaredMethod("writeObject", Object.class, boolean.class); |
| 58 | + writeObjectMethod.setAccessible(true); |
| 59 | + writeObjectMethod.invoke(message, value, true); |
| 60 | + |
| 61 | + queueSender.send(message); |
| 62 | + } finally { |
| 63 | + reconnect(Arrays.asList("java.lang", "com.rabbitmq.jms")); |
| 64 | + } |
| 65 | + |
| 66 | + queueConn.start(); |
| 67 | + QueueSession queueSession = queueConn.createQueueSession(false, Session.DUPS_OK_ACKNOWLEDGE); |
| 68 | + Queue queue = queueSession.createQueue(QUEUE_NAME); |
| 69 | + QueueReceiver queueReceiver = queueSession.createReceiver(queue); |
| 70 | + RMQStreamMessage m = (RMQStreamMessage) queueReceiver.receive(TEST_RECEIVE_TIMEOUT); |
| 71 | + MessageTestType.STREAM.check(m, null); |
| 72 | + assertEquals(m.readObject(), value); |
| 73 | + } |
| 74 | + |
| 75 | + @Test |
| 76 | + public void testReceiveStreamMessageWithPrimitiveValue() throws Exception { |
| 77 | + testReceiveStreamMessageWithValue(1024L); |
| 78 | + testReceiveStreamMessageWithValue("a string"); |
| 79 | + } |
| 80 | + |
| 81 | + @Test |
| 82 | + public void testReceiveStreamMessageWithTrustedValue() throws Exception { |
| 83 | + testReceiveStreamMessageWithValue(new TestMessages.TestSerializable(8, "An object")); |
| 84 | + } |
| 85 | + |
| 86 | + @Test |
| 87 | + public void testReceiveStreamMessageWithUntrustedValue1() throws Exception { |
| 88 | + // StreamMessage cannot be used with a Map, unless the sender uses a trick |
| 89 | + // this is to simulate an attack from the sender |
| 90 | + // Note: java.util is not on the trusted package list |
| 91 | + assertThrows(RMQJMSException.class, () -> { |
| 92 | + Map<String, String> m = new HashMap<String, String>(); |
| 93 | + m.put("key", "value"); |
| 94 | + testReceiveStreamMessageWithValue(m); |
| 95 | + }); |
| 96 | + } |
| 97 | + @Test |
| 98 | + public void testReceiveStreamMessageWithUntrustedValue2() throws Exception { |
| 99 | + // StreamMessage cannot be used with a Map, unless the sender uses a trick |
| 100 | + // this is to simulate an attack from the sender |
| 101 | + // java.awt is not on the trusted package list |
| 102 | + assertThrows(RMQJMSException.class, () -> { |
| 103 | + testReceiveStreamMessageWithValue(Color.WHITE); |
| 104 | + }); |
| 105 | + } |
| 106 | + |
| 107 | + protected void reconnect(java.util.List<String> trustedPackages) throws Exception { |
| 108 | + if (queueConn != null) { |
| 109 | + this.queueConn.close(); |
| 110 | + ((RMQConnectionFactory) connFactory).setTrustedPackages(trustedPackages); |
| 111 | + this.queueConn = connFactory.createQueueConnection(); |
| 112 | + } else { |
| 113 | + fail("Cannot reconnect"); |
| 114 | + } |
| 115 | + } |
| 116 | +} |
| 117 | + |
0 commit comments